Devicetree
 help / color / mirror / Atom feed
From: Sean Nyekjaer <sean@geanix.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Nuno Sá" <Nuno.Sa@analog.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers
Date: Tue, 27 Apr 2021 17:11:50 +0200	[thread overview]
Message-ID: <5110607a-c94a-d833-fd7d-52bd40d35b79@geanix.com> (raw)
In-Reply-To: <CAHp75VdEHy0-F-pg8sSUF5FK=NfDgBuDj0wLWqpGjpqE11mjww@mail.gmail.com>



On 23/04/2021 14.51, Andy Shevchenko wrote:
>> +               default:
>> +                       ret = -EINVAL;
>> +                       break;
> return -EINVAL;
>
>> +               }
>> +
>> +               iio_device_release_direct_mode(indio_dev);
Hi Andy,

Thanks for the review :)
Will have to set ret in order to clear the direct_mode();

/Sean

  parent reply	other threads:[~2021-04-27 15:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 10:19 [PATCH v2 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Sean Nyekjaer
2021-04-23 10:19 ` [PATCH v2 2/2] dt-bindings: iio: accel: fxls8962af: add bindings Sean Nyekjaer
2021-04-24 10:29   ` Jonathan Cameron
2021-04-23 12:51 ` [PATCH v2 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Andy Shevchenko
2021-04-24 10:43   ` Jonathan Cameron
2021-04-27 15:11   ` Sean Nyekjaer [this message]
2021-04-27 15:30     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5110607a-c94a-d833-fd7d-52bd40d35b79@geanix.com \
    --to=sean@geanix.com \
    --cc=Nuno.Sa@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox