devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: kernel@collabora.com, Yong Wu <yong.wu@mediatek.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8192: Add missing dma-ranges to soc node
Date: Mon, 5 Jun 2023 11:45:10 +0200	[thread overview]
Message-ID: <511269ce-2493-1d21-d8fe-a9d78828e018@collabora.com> (raw)
In-Reply-To: <20230601203221.3675915-1-nfraprado@collabora.com>

Il 01/06/23 22:32, Nícolas F. R. A. Prado ha scritto:
> In the series "Adjust the dma-ranges for MTK IOMMU", the mtk-iommu
> driver was adapted to separate the iova range based on the larb used,
> and a dma-ranges property was added to the soc node in the devicetree of
> the affected SoCs allowing the whole 16GB iova range to be used. Except
> that for mt8192, there was no patch adding dma-ranges.
> 
> Add the missing dma-ranges property to the soc node like was done for
> mt8195 and mt8186. This fixes the usage of the vcodec, which would
> otherwise trigger iommu faults.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> ---
> Matthias,
> 
> this is a very simple but important fix for the vcodec functionality.
> Since the vcodec node for mt8192 was just merged, can we please get this
> in in this merge window as well?

+1

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> 
> Thanks,
> Nícolas
> 
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 7ff183c35494..a3612de8e9d1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -401,6 +401,7 @@ soc {
>   		#address-cells = <2>;
>   		#size-cells = <2>;
>   		compatible = "simple-bus";
> +		dma-ranges = <0x0 0x0 0x0 0x0 0x4 0x0>;
>   		ranges;
>   
>   		gic: interrupt-controller@c000000 {


  reply	other threads:[~2023-06-05  9:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 20:32 [PATCH] arm64: dts: mediatek: mt8192: Add missing dma-ranges to soc node Nícolas F. R. A. Prado
2023-06-05  9:45 ` AngeloGioacchino Del Regno [this message]
2023-06-06  6:34   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511269ce-2493-1d21-d8fe-a9d78828e018@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).