From: Jon Hunter <jon-hunter@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Tony Lindgren <tony@atomide.com>,
Benoit Cousson <b-cousson@ti.com>,
Vinod Koul <vinod.koul@intel.com>,
Russell King <linux@arm.linux.org.uk>,
Matt Porter <mporter@ti.com>, Balaji T K <balajitk@ti.com>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
Felipe Balbi <balbi@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Sourav Poddar <sourav.poddar@ti.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver
Date: Fri, 8 Feb 2013 09:23:24 -0600 [thread overview]
Message-ID: <5115186C.2070406@ti.com> (raw)
In-Reply-To: <201302071439.13720.arnd@arndb.de>
On 02/07/2013 08:39 AM, Arnd Bergmann wrote:
> On Wednesday 06 February 2013, Jon Hunter wrote:
>> +static struct of_dma_filter_info info;
>
> Both members of this structure are constant, so you can just initialize it here,
> and it would be nice to give it a more descriptive name, such as omap_dmadev_info.
No problem. By the way, I see the dma_cap_mask_t is defined as follows ...
typedef struct { DECLARE_BITMAP(bits, DMA_TX_TYPE_END); } dma_cap_mask_t;
Is there a good way to statically initialise this?
Cheers
Jon
next prev parent reply other threads:[~2013-02-08 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 21:03 [PATCH 0/2] ARM: dts: Add DT bindings for OMAP SDMA Jon Hunter
2013-02-06 21:03 ` [PATCH 1/2] ARM: dts: OMAP2+: Add SDMA controller bindings and nodes Jon Hunter
[not found] ` <1360184596-1603-2-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2013-02-07 14:39 ` Arnd Bergmann
2013-02-06 21:03 ` [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver Jon Hunter
2013-02-06 21:14 ` Jon Hunter
[not found] ` <1360184596-1603-3-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2013-02-07 14:39 ` Arnd Bergmann
2013-02-07 15:51 ` Jon Hunter
2013-02-07 16:07 ` Arnd Bergmann
2013-02-08 0:52 ` Jon Hunter
2013-02-08 1:44 ` Tony Lindgren
[not found] ` <20130208014402.GA7556-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-02-08 18:52 ` Jon Hunter
2013-02-08 15:23 ` Jon Hunter [this message]
2013-02-09 10:52 ` Russell King - ARM Linux
2013-02-07 8:39 ` [PATCH 0/2] ARM: dts: Add DT bindings for OMAP SDMA Felipe Balbi
2013-02-07 13:18 ` Peter Ujfalusi
2013-02-07 14:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5115186C.2070406@ti.com \
--to=jon-hunter@ti.com \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mporter@ti.com \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).