From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Subject: Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation
Date: Wed, 13 Feb 2013 23:32:02 +0100
Message-ID: <511C1462.5060106@gmail.com>
References: <1360151477-26460-1-git-send-email-sachin.kamat@linaro.org> <1360151477-26460-8-git-send-email-sachin.kamat@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-samsung-soc-owner@vger.kernel.org>
In-Reply-To: <1360151477-26460-8-git-send-email-sachin.kamat@linaro.org>
Sender: linux-samsung-soc-owner@vger.kernel.org
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, s.nawrocki@samsung.com, inki.dae@samsung.com, patches@linaro.org
List-Id: devicetree@vger.kernel.org

On 02/06/2013 12:51 PM, Sachin Kamat wrote:
> Added documentaion about G2D bindings.

s/documentaion/documentation

> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
>   .../devicetree/bindings/gpu/samsung-g2d.txt        |   30 ++++++++++++++++++++
>   1 files changed, 30 insertions(+), 0 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> new file mode 100644
> index 0000000..838b26b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> @@ -0,0 +1,30 @@
> +* Samsung 2D Graphics Accelerator
> +

> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer.
> +We set the drawing-context registers for configuring the rendering parameters
> +and then start rendering.
> +The G2D has V4L2 as well as DRM framework based driver support.

IMHO this whole paragraph is irrelevant and could be dropped.

> +Required properties:
> +  - compatible : value should be one among the following

missing colon at the end of line ?

> +	(a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210&  Exynos4210 SoC
> +	(b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
> +	(b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC

s/(b)/(c)

> +
> +  - reg : Physical base address of the IP registers and length of memory
> +	  mapped region.
> +
> +  - interrupts : G2D interrupt number to the CPU.
> +
> +Optional properties:
> +  - samsung,power-domain : power-domain property defined with a phandle
> +			   to respective power domain.
> +
> +Example:
> +	g2d@12800000 {
> +		compatible = "samsung,s5pv210-g2d";
> +		reg =<0x12800000 0x1000>;
> +		interrupts =<0 89 0>;
> +		samsung,power-domain =<&pd_lcd0>;
> +		status = "disabled";
> +	};

Otherwise looks good to me.