From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH v2 1/2] [media] s5p-g2d: Add DT based discovery support Date: Thu, 14 Feb 2013 00:34:35 +0100 Message-ID: <511C230B.5060302@gmail.com> References: <1360128584-23167-1-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-media-owner@vger.kernel.org To: Sachin Kamat Cc: "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "devicetree-discuss@lists.ozlabs.org" , "k.debski@samsung.com" , "kgene.kim@samsung.com" , "patches@linaro.org" , "inki.dae@samsung.com" , "s.nawrocki@samsung.com" List-Id: devicetree@vger.kernel.org On 02/12/2013 06:30 PM, Sachin Kamat wrote: > > Hi Sylwester, > > On Wednesday, 6 February 2013, Sachin Kamat wrote: >> This patch adds device tree based discovery support to G2D driver >> >> Signed-off-by: Sachin Kamat >> --- >> Based on for_v3.9 branch of below tree: >> git://linuxtv.org/snawrocki/samsung.git >> >> Changes since v1: >> * Addressed review comments from Sylwester . >> * Modified the compatible string as per the discussions at [1]. >> [1] https://patchwork1.kernel.org/patch/2045821/ >> > > Does this patch look good? It looks OK to me. I've sent a pull request including it, but it may happen it ends up only in 3.10. I tried to test this patch today and I had to correct some clock definitions in the common clock API driver [1]. And we already have quite a few fixes to that patch series. Shouldn't you also provide a patch adding related OF_DEV_AUXDATA entry ? How did you test this one ? When the new clocks driver gets merged (I guess it happens only in 3.10) I'd like to have the media devices' clock names cleaned up, instead of names like: {"sclk_fimg2d", "fimg2d"}, {"sclk_fimc", "fimc"}, {"sclk_fimd"/"fimd"}, in clock-names property we could have common names, e.g. { "sclk", "gate" }. This could simplify a bit subsystems like devfreq. Also I noticed there are some issues caused by splitting mux + div + gate clocks into 3 different clocks. One solution to this might be to use the new composite clock type. [1] http://www.spinics.net/lists/arm-kernel/msg214149.html