From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Padmavathi Venna <padma.v@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
padma.kvr@gmail.com, linux-samsung-soc@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
sbkim73@samsung.com, vinod.koul@intel.com,
grant.likely@secretlab.ca, swarren@nvidia.com,
boojin.kim@samsung.com, kgene.kim@samsung.com,
jassisinghbrar@gmail.com, thomas.abraham@linaro.org, lrg@ti.com,
tiwai@suse.de, ben-linux@fluff.org
Subject: Re: [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s
Date: Thu, 14 Feb 2013 21:33:00 +0100 [thread overview]
Message-ID: <511D49FC.4080402@gmail.com> (raw)
In-Reply-To: <20130214114337.GD13249@opensource.wolfsonmicro.com>
On 02/14/2013 12:43 PM, Mark Brown wrote:
> On Thu, Feb 14, 2013 at 11:48:59AM +0100, Sylwester Nawrocki wrote:
>
>> NAK.
>
>> Why we should live with this temporary code when there is already
>> pinctrl support for Exynos SoCs ?
>
>> If the pinctrl driver for Exynos5 was updated you could instead just do
>
>> devm_pinctrl_get_select_default(&i2s->pdev->dev);
>
> Too late, this stuff is already merged and on its way upstream.
My apologies for the late review. It's already sixth version of this patch
series... But I noticed it just now when applying it for Exynos4. The GPIO
part of the bindings is now incompatible with Exynos4 and the bindings will
need to be changed. Leaving the compatibility code in the I2S driver, when
we could have it done well right from the beginning. If I'm not mistaken
a file similar to arch/arm/boot/dts/exynos4x12-pinctrl.dtsi with at least
entries for the I2S devices is needed and an addition of related pinctrl
nodes in exynos5250.dtsi. But I guess this is not something that could be
fixed in the -rc period ?
next prev parent reply other threads:[~2013-02-14 20:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 11:46 [PATCH V6 00/10] Add DT support for i2s Padmavathi Venna
2013-01-18 11:47 ` [PATCH V6 01/10] ASoC: Samsung: Rename samsung i2s secondary device name Padmavathi Venna
2013-01-24 6:41 ` Mark Brown
2013-01-18 11:47 ` [PATCH V6 02/10] ASoC: SAMSUNG: Add DT support for i2s Padmavathi Venna
2013-02-14 10:29 ` Sylwester Nawrocki
2013-02-14 10:48 ` Sylwester Nawrocki
2013-02-14 11:05 ` Tomasz Figa
2013-02-14 11:43 ` Mark Brown
2013-02-14 20:33 ` Sylwester Nawrocki [this message]
2013-02-15 12:01 ` Mark Brown
2013-02-17 0:31 ` Padma Venkat
2013-01-18 11:47 ` [PATCH V6 03/10] ARM: SAMSUNG: Make dma request compatible to generic dma bindings Padmavathi Venna
2013-01-29 6:20 ` Mark Brown
2013-01-29 9:30 ` Padma Venkat
2013-01-18 11:47 ` [PATCH V6 04/10] spi: s3c64xx: Modify SPI driver to use generic DMA DT support Padmavathi Venna
2013-01-29 5:19 ` Mark Brown
2013-01-29 9:32 ` Padma Venkat
2013-01-18 11:47 ` [PATCH V6 05/10] ARM: dts: Add nodes for i2s controllers for Samsung Exynos5 platforms Padmavathi Venna
2013-01-18 11:47 ` [PATCH 06/10] ARM: EXYNOS: Enable platform support for I2S controllers Padmavathi Venna
2013-01-18 11:47 ` [PATCH V6 07/10] ASoC: SMDK: WM8994: Add device tree support for machine file Padmavathi Venna
2013-01-29 7:12 ` Mark Brown
2013-01-29 9:39 ` Padma Venkat
2013-01-18 11:47 ` [PATCH V6 08/10] ARM: dts: Modify SPI nodes according generic DMA DT bindings Padmavathi Venna
2013-01-29 7:39 ` Mark Brown
2013-01-18 11:47 ` [PATCH V6 09/10] ASoC: Samsung: Update Kconfig for I2S,SPDIF and PCM audio Padmavathi Venna
2013-01-29 7:40 ` Mark Brown
2013-01-18 11:47 ` [PATCH V6 10/10] dmaengine: Fix compilation error in non-DT case Padmavathi Venna
2013-01-27 3:39 ` Mark Brown
2013-01-28 13:47 ` Vinod Koul
2013-01-29 8:53 ` Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511D49FC.4080402@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=boojin.kim@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@ti.com \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=swarren@nvidia.com \
--cc=thomas.abraham@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).