From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE0A12DA759 for ; Tue, 16 Jun 2026 09:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781603150; cv=none; b=bjT2rAg1qIidov+wfDqkiavSAHgdL/MQDkoTProjo9wo8IQhSOvqyUSrxepHtiQ0stlD2KVptBgZxaGS6S2oxtV4oisNYDgoKOZfpMswXKJ46K+5FKT2mS3Lb2XqzNwOUU8n7w8f0+cOnmUpDpo/I1bSuqJGaFiBCT+/mheQ1A0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781603150; c=relaxed/simple; bh=LC7dDtmk+ZW/FYQaJQ4mv5Z0clS776B0o/QgDFWksAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=geAvhj5dXqChpUS2JmjNEc7UE/tQQWyFNTNCp0IhE4zrnlcNs5U50btH71yEQtpM3MRvqGKM0P6/vyPULzw3OLx4K1pJitQWOWFJQ4Zv2nZkorTJSuvW8y3VcPMrO+yhSLh4mmI3we7xIG7G0fc/K7A/b+ahUwOdcDSzwAk8QGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U3QF9A08; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MjHvrKRW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U3QF9A08"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MjHvrKRW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65G64ccX2911806 for ; Tue, 16 Jun 2026 09:45:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0aEEZ+OkgRg4egXxqmcIcO+IisKGYk8Fwd2iLOFyAnQ=; b=U3QF9A080EZPWBs6 H2V2Y8Hb7OTLlO9XK7w34lQLF8XIKvwWeacYlq+dULEUwalseVno75iBhP9uGOVJ wsgqxBJWAcSogMyaLXrE3Nj2q38bMr2Obi6tBYGikOZJHhi8ivB8Xhhdd5TNhN6d GBALD4JTKbC4Xu7Nv55UIMrpQFHuUzdHSVwlz1Vj6fMxJbhxyeb0diOtvOypnlN9 en6+Wg2uVcf/9UsKFQwwVwzeDIQ+SnAy8nRuc5pRfRjyJuZo9vkNjHOW8yDP9K1v XbJ9I/8f+ucs8L7pQeVKvwjjetVlptC86ch02lLJyZByiZj4HLQRDWDeytIg5KDL KB9Zsw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ety52sbka-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 09:45:47 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5176891d0a9so10679281cf.0 for ; Tue, 16 Jun 2026 02:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781603147; x=1782207947; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0aEEZ+OkgRg4egXxqmcIcO+IisKGYk8Fwd2iLOFyAnQ=; b=MjHvrKRWS20Xg5pInBp+IvYysNYLAIvY96Nd44K+c4wR62Zvve5IXfdqcIbVpEzYHd ey1UjxNiJYZn3KRNe9H/4BqwodlP89jYIvcsq8vn+bUExtZe+zVo1/SWn/95Vq42Hwd7 cBMLeTa/+9UVC5V9cj0XUxIrsV1h+Mf0guH6QPxH4YL1MxfcIAWs6ejNIrNJpBL1HUcm Zi4SmPlNa3B1zNu+0SCoI+FinOEG73bnWRy4nxBckgC46rC1dFLAdOPdDhCPV49Q5jMO K24Okk63Rqi9523APfvdi864C9tMe8DjNgQm5JJ5M8XFt2Kmcb/5BIbakPGgK0MaRT9I zXaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781603147; x=1782207947; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0aEEZ+OkgRg4egXxqmcIcO+IisKGYk8Fwd2iLOFyAnQ=; b=pmd11482HahQAD9ZEaCVITkZM7oTSNVZMP8Or1HlTh2cxT6Zf0vlEhOYTskyWOxUxu 07kWjbcgewuiLbkqS7eVB+FFvTFkSKGjCMX1zE3MMLS9ndDs/nRK1zOf+bEKNCdFxbcm kKlyOuQ6wNipDpllmLAHoy8rMnRee8lsQYDe2OENTS+A3fCteRI+1sqV4JQGeHMVqnaS 4WUKp1IO/kaWiEmZooU77i8MJWCDjj+Km1aAWhlCLUcRXq6wLEmccKDUEtf++PT7qay8 4nPwRgNi1j3wOJHJniBtjr8z76VhrtRmxlZAL2u2rm2W0FJOGCQ1kOoIWN9zAJvuAE8i H5DQ== X-Forwarded-Encrypted: i=1; AFNElJ/Mslce/XSOzanLfX8b0hosUKgi1quBi2V5uDUTBr69xlIL8ThlDVZNHFI8XF/byItMU5HWel173Jfo@vger.kernel.org X-Gm-Message-State: AOJu0Yw6BDokI1mY+68ezvBAmwWl1SmBiGKf3jgqlUaEKvNb1Mxkpi+F 9zsYBsl90PJCnWxnSHDHiGBna9P3qElgoBh3rZuM1TTnlgah/HppeIKciuiuz/iBTZ48dI+N5QW BoCWcBAUr2vfJOqec9zV1p3wYk0uyHOQoR7cUDO+3jyFItxadlCS7orpBVfQafcAT X-Gm-Gg: Acq92OGLwptKH9LYesCqVQHdhps5T+deZyfx/KA21AipcQfZHfb3NitCi6wkdREnQRK ZKktH43k1rRPFITDAQPOnnr+XrRTcMgh/QFfzUSagEdTrDG4SyIzofKVjxb7gfq7axB12hZYlKo M2zWVIQ26eebCMT74RuOY9L+9uDTCN23ABLK50GfeL+4n9MdOlbAjSDzfa7Z5Np6Mw4WNvZGXlt 9tguS4bU4NS5CElyUp4o0AJfJI1vxgiYoYyMKgG1XlZ6lj2yfwUcfyvfToookicY1a77LWH7SKI r9FkIC0NGixjMTHjWhR4dcshpNn30JTAgQWTtreS8N/RXDdcWt2PdpYaJm0goKiQI3BX98STeG1 y0VRKy02Yj1ZSHaRlVXd6s3OPdJQ+Xc7FypOd94uNdq99eA== X-Received: by 2002:ac8:5855:0:b0:50b:3489:5495 with SMTP id d75a77b69052e-517fe49783amr170523221cf.8.1781603147165; Tue, 16 Jun 2026 02:45:47 -0700 (PDT) X-Received: by 2002:ac8:5855:0:b0:50b:3489:5495 with SMTP id d75a77b69052e-517fe49783amr170522931cf.8.1781603146627; Tue, 16 Jun 2026 02:45:46 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8341840sm623721966b.43.2026.06.16.02.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 02:45:45 -0700 (PDT) Message-ID: <511f53cf-0f1c-450f-b55f-cc7f3dcd73b0@oss.qualcomm.com> Date: Tue, 16 Jun 2026 11:45:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver To: Daniel Lezcano , Manaf Meethalavalappu Pallikunhi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Gaurav Kohli References: <20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com> <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> <7ea2f2cc-ef11-4727-810c-e32e815bd973@oss.qualcomm.com> <8f045340-a6c8-41c7-b1c7-6d9b87b05d90@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDA5OCBTYWx0ZWRfX2vyy165oC3iq 2Cx7dA6EAZx/oB5oEIjeZPlVxSo+ueIfD148jEwWwk8klfZEwEsVauPKASbnNH8jfc6NBxCSR2F vnSG4TcZKmI/hLuvXjEvHoTW0GGW65M= X-Authority-Analysis: v=2.4 cv=FJwrAeos c=1 sm=1 tr=0 ts=6a311b4b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=iXSNKydA93grDqh3_akA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDA5OCBTYWx0ZWRfX31yKl7cB5S28 OY+3AWYOp5E6ZuOyiWDeUNwdU3k6AmilujqW64Mk6caH81xpH1fHUgV/BxzrevqECc5tNfmGI9A e8+ofHEQoZ+5tV0dG5vRZvyWgrKjmowVtbzT0xZRho4I31f3+mcCy/iJDx2X8wcBLiR3WRCQdpJ wl4rUPNdHnlanj/TJGuP41l98dXes1r4Q/7xV3VwiscbQXrH46gZPmMRkgYEKNe/vgBLhETZkO1 jrhVpnL0SY1hgPdI/wKyWRt5DrOZbeA7yfqZPGXsgMFwUQBOnpkZ+l9o9NDYoRsWML/W6u/DjHQ Rg6jCh57QuI+N2uCJtrs07UZvYYl3gHmC6MwNDtSU06g80Qdb6yzZ1qdtFejsgljr2ouyUs2AWn TeTZX32zlAogIgeM5He8tHKrQ2gSRN5DwHSYxTOukOaATO+0CTywSqAP+/T0FWuMfbZkzz977AY KXs0Uo0OM395M3p0SlA== X-Proofpoint-ORIG-GUID: NG45yRknWJUnB6JGNnM9CZdo2eWkuZ6c X-Proofpoint-GUID: NG45yRknWJUnB6JGNnM9CZdo2eWkuZ6c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_02,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160098 On 6/15/26 2:07 PM, Daniel Lezcano wrote: > Hi Konrad, > > Le 09/06/2026 à 15:31, Konrad Dybcio a écrit : >> On 6/9/26 3:23 PM, Manaf Meethalavalappu Pallikunhi wrote: >>> Hi Konrad, >>> >>> >>> On 5/21/2026 4:46 PM, Konrad Dybcio wrote: >>>> On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote: >>>>> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >>>>> based power monitoring and limiting capabilities for various power >>>>> domains including System, SoC, CPU clusters, GPU, and various other >>>>> subsystems. >>>>> >>>>> The driver integrates with the Linux powercap framework, exposing SPEL >>>>> capabilities through powercap sysfs interfaces. >>>>> >>>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>>>> --- >> >> [...] >> >>>>> +static void spel_remove(struct platform_device *pdev) >>>>> +{ >>>>> +    struct spel_system *sp = platform_get_drvdata(pdev); >>>>> +    int i; >>>>> + >>>>> +    if (!sp) >>>>> +        return; >>>>> + >>>>> +    /* Unregister in reverse order: children first, then SOC, then SYS */ >>>>> +    for (i = SPEL_DOMAIN_MAX - 1; i >= 0; i--) >>>>> +        powercap_unregister_zone(sp->control_type, &sp->domains[i].power_zone); >>>> >>>> Could you try adding a devm_ variant of these register functions? >>> >>> Powercap framework doesn't support any devm_* API, you meant add this support in framework in this series ? >> >> Yes, this should be fairly trivial - look at e.g. >> >> drivers/regulator/devres.c : devm_of_regulator_get > > Given how structured is the powercap framework, I'm not sure it is so trivial. May be it is, but I doubt. > > I don't think it is worth to investigate adding devm_ variant now (for a few lines saved) and diverge from the objective of this series Might as well be, looks like the powercap zones are "namespaced" inside powercap controllers, so it's not that trivial Konrad