From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 Date: Tue, 19 Feb 2013 17:58:36 +0800 Message-ID: <51234CCC.2060909@nvidia.com> References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-5-git-send-email-wni@nvidia.com> <5123100A.9050604@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5123100A.9050604-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Courbot Cc: "durgadoss.r-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , Matthew Longnecker , "khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 02/19/2013 01:39 PM, Alex Courbot wrote: > On 02/18/2013 08:30 PM, Wei Ni wrote: >> Using macros for the indexes and nrs of temp8 and temp11. >> This make the code much clearer. >> >> Signed-off-by: Wei Ni > > Acked-by: Alexandre Courbot > > Great patch. This makes the code much more readable. I also compiled > lm90.o before and after this patch, and diff'ed the stripped binaries to > make sure there was no error in the macro indexes. Both binaries were > indentical, therefore: > > Tested-by: Alexandre Courbot Great, thanks for your test, I will do it in my next version. Wei. > > Alex. > >