From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Olivier Benjamin <olivier.benjamin@bootlin.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Olivier Benjamin <olivier.benjamin@bootlin.com>,
Dragan Simic <dsimic@manjaro.org>, Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH 0/2] Describe the cameras in the PinePhone Pro dts
Date: Fri, 31 Jan 2025 10:20:06 +0100 [thread overview]
Message-ID: <5127541.31r3eYUQgx@phil> (raw)
In-Reply-To: <20250119-camera-v1-0-320be4f0dc2b@bootlin.com>
Hi,
Am Sonntag, 19. Januar 2025, 23:56:58 MEZ schrieb Olivier Benjamin:
> This series adds support for the Pine64 PinePhone Pro's rear and front
> cameras in Device Tree.
> This is based on some of Ondrej Jirman's patches hosted in his tree at
> https://codeberg.org/megi/linux, but I have also fully reviewed and
> re-written the code from the RK3399 datasheet, the PinePhone Pro
> schematic, and the IMX258-0AQH5 software reference manual.
>
> I have tested these changes on my PinePhone Pro and am able to take
> photos from both cameras using libcamera's cam.
>
> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
> ---
> Olivier Benjamin (2):
> arm64: dts: PinePhone Pro: describe I2c Bus 1 and IMX258 world camera
> arm64: dts: PinePhone Pro: describe the OV8858 user camera
Patch subject should be
"arm64: dts: rockchip: describe the OV8858 user camera on PinePhone Pro"
patches need an update to accomodate
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5c96e63301978f4657c9082c55a066763c8db7b1
And please name the new regulator nodes similarly
(regulator-foo)
Thanks a lot
Heiko
next prev parent reply other threads:[~2025-01-31 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 22:56 [PATCH 0/2] Describe the cameras in the PinePhone Pro dts Olivier Benjamin
2025-01-19 22:56 ` [PATCH 1/2] arm64: dts: PinePhone Pro: describe I2c Bus 1 and IMX258 world camera Olivier Benjamin
2025-01-19 22:57 ` [PATCH 2/2] arm64: dts: PinePhone Pro: describe the OV8858 user camera Olivier Benjamin
2025-01-31 9:20 ` Heiko Stuebner [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-28 15:19 [PATCH 0/2] Describe the cameras in the PinePhone Pro dts Olivier Benjamin
2025-02-28 15:46 ` Dragan Simic
2025-02-28 17:24 ` Olivier Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5127541.31r3eYUQgx@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=megi@xff.cz \
--cc=olivier.benjamin@bootlin.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).