From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/5 v7][RFC] ASoC: add snd_soc_register_cpu() Date: Thu, 28 Feb 2013 12:14:52 -0700 Message-ID: <512FACAC.1000808@wwwdotorg.org> References: <87zk11487a.wl%kuninori.morimoto.gx@renesas.com> <20130127035943.GJ4650@opensource.wolfsonmicro.com> <87vcag3hcj.wl%kuninori.morimoto.gx@renesas.com> <20130129014808.GC4748@opensource.wolfsonmicro.com> <87sj5k3f83.wl%kuninori.morimoto.gx@renesas.com> <87obg8z4u4.wl%kuninori.morimoto.gx@renesas.com> <5107FF97.1070601@wwwdotorg.org> <87halz82bm.wl%kuninori.morimoto.gx@renesas.com> <51097F0F.2030501@wwwdotorg.org> <87halw7sij.wl%kuninori.morimoto.gx@renesas.com> <5110349D.3050308@wwwdotorg.org> <87ehgvrs1h.wl%kuninori.morimoto.gx@renesas.com> <87bobzrry6.wl%kuninori.morimoto.gx@renesas.com> <511963F8.5020107@wwwdotorg.org> <87bobqf5yq.wl%kuninori.morimoto.gx@renesas.com> <511C22E2.60701@wwwdotorg.org> <87obfnofsx.wl%kuninori.morimoto.gx@renesas.com> <511C6A1B.9000507@wwwdotorg.org> <874nhfv5mb.wl%kuninori.morimoto.gx@renesas.com> <8738wzuu9g.wl%kuninori.morimoto.gx@renesas.com> <87a9qsg4lp.wl%kuninori.morimoto.gx@renesas.com> <87mwuptgju.wl%kuninori.morimoto.gx@renes as.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87mwuptgju.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Kuninori Morimoto Cc: Linux-ALSA , Lars-Peter Clausen , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Mark Brown , Liam Girdwood , Simon , Kuninori Morimoto List-Id: devicetree@vger.kernel.org On 02/27/2013 05:42 PM, Kuninori Morimoto wrote: > > Hi Stephen > >> On 02/25/2013 01:51 AM, Kuninori Morimoto wrote: >>> Current ASoC has register function for platform/codec/dai/card, >>> but doesn't have for cpu. >>> It often produces confusion and fault on ASoC. >>> This patch adds very basic register function for cpu >> >> This seems reasonable to me. >> >> I can't recall how much influence the existing CODEC objects have on the >> various routing/matching decisions inside the ASoC core. While this >> patch does register and unregister CPU objects, I wonder if it should >> have more impact on any of the existing core code? Certainly I'd expect >> the CPU objects to show up in ASoC's debugfs and any similar files... > > This patch doesn't have any impact to existing drivers. > It just added new cpu list. Sure. My point was that now you've added the list, perhaps the core ASoC code might want to make use of it in the same way it makes use of CODEC objects, since it's logically equivalent. Perhaps this could be a separate set of follow-on patches. That's all entirely Mark's call.