From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] : fix compilation warnings with DT disabled Date: Fri, 01 Mar 2013 07:46:23 -0600 Message-ID: <5130B12F.20409@gmail.com> References: <201302190258.25726.sergei.shtylyov@cogentembedded.com> <20130301070925.GA24369@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20130301070925.GA24369@verge.net.au> Sender: linux-sh-owner@vger.kernel.org To: Simon Horman , Sergei Shtylyov Cc: linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, vladimir.barinov@cogentembedded.com List-Id: devicetree@vger.kernel.org On 03/01/2013 01:09 AM, Simon Horman wrote: > On Tue, Feb 19, 2013 at 02:58:25AM +0300, Sergei Shtylyov wrote: >> Fix the following compilation warnings (in Simon Horman's renesas.gi= t repo): >> >> In file included from arch/arm/mach-shmobile/setup-r8a7779.c:24:0: >> include/linux/of_platform.h:107:13: warning: =E2=80=98struct of_devi= ce_id=E2=80=99 declared >> inside parameter list [enabled by default] >> include/linux/of_platform.h:107:13: warning: its scope is only this = definition >> or declaration, which is probably not what you want [enabled by defa= ult] >> include/linux/of_platform.h:107:13: warning: =E2=80=98struct device_= node=E2=80=99 declared >> inside parameter list [enabled by default] >> >> only #include's headers with definitions of th= e above >> mentioned structures if CONFIG_OF_DEVICE=3Dy but uses them even if n= ot. One >> solution is to move some #include's out of #ifdef CONFIG_OF_DEVICE a= nd use >> incomplete declarations for the rest of the structures where the #if= def move >> doesn't help... >> >> Reported-by: Vladimir Barinov >> Signed-off-by: Sergei Shtylyov >=20 > Reviewed-by: Simon Horman >=20 > Grant, could you consider taking this patch? Yes, I can, but I don't seem to have the original patch. Can you send i= t again. >> --- >> Actually, it compiles eve without 'struct device_node' declared, I h= aven't >> found the reason of this, so left it there... device.h has a forward declaration of it. Rob