From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, javier@osg.samsung.com,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration
Date: Thu, 01 Sep 2016 13:17:13 +0200 [thread overview]
Message-ID: <5137342.oSWmFr9Y8D@wuerfel> (raw)
In-Reply-To: <e37fbfa0-f30c-ab34-3428-fb9a66182089@samsung.com>
On Thursday, September 1, 2016 1:12:18 PM CEST Krzysztof Kozlowski wrote:
> >
> > Shouldn't macros that are also used by s3c* be named as
> > SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?
>
> Right, this is the inconsistency. The problem with "samsung" prefix is
> that there is no guarantee it will be like that for newer SoCs. How
> about one of:
> 1. using the oldest prefix (S3C24XX in this case),
> 2. duplicating them per SoC family (so S3C24XX, S3C64XX, EXYNOS).
> ?
I'd suggest living with the inconsistency and using EXYNOS as the prefix,
as that is the most common one these days, even if the other ones
predate it.
Arnd
next prev parent reply other threads:[~2016-09-01 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 9:21 [PATCH 0/6] pinctrl: s3c/samsung: Add header with values used for configuration Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 2/6] pinctrl: dt-bindings: samsung: Add macros for S3C64xx pin configuration Krzysztof Kozlowski
[not found] ` <1472721715-2833-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-01 9:21 ` [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros Krzysztof Kozlowski
2016-09-01 10:29 ` Javier Martinez Canillas
2016-09-01 10:31 ` Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 3/6] ARM: dts: s3c64xx: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 4/6] ARM: dts: s5pv210: Use " Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 5/6] ARM: dts: s3c2416: " Krzysztof Kozlowski
2016-09-01 10:59 ` Bartlomiej Zolnierkiewicz
2016-09-01 11:12 ` Krzysztof Kozlowski
2016-09-01 11:17 ` Arnd Bergmann [this message]
2016-09-01 9:21 ` [PATCH 6/6] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2016-09-01 10:53 ` [PATCH 0/6] pinctrl: s3c/samsung: Add header with values used for configuration Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5137342.oSWmFr9Y8D@wuerfel \
--to=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).