From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH 1/3] can: at91_can: add dt support Date: Mon, 11 Mar 2013 16:59:40 +0100 Message-ID: <513DFF6C.2050408@pengutronix.de> References: <1362763842-14924-1-git-send-email-ludovic.desroches@atmel.com> <1362763842-14924-2-git-send-email-ludovic.desroches@atmel.com> <513A2365.5050803@pengutronix.de> <20130311091722.GA2572@ludovic.desroches@atmel.com> <513DF46E.7000903@pengutronix.de> <20130311153956.GB3198@ludovic.desroches@atmel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2SPIDKVGVXOTBXUCWNAAQ" Return-path: In-Reply-To: <20130311153956.GB3198@ludovic.desroches@atmel.com> Sender: linux-can-owner@vger.kernel.org To: Ludovic Desroches Cc: linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, nicolas.ferre@atmel.com, plagnioj@jcrosoft.com List-Id: devicetree@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SPIDKVGVXOTBXUCWNAAQ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/11/2013 04:39 PM, Ludovic Desroches wrote: > On Mon, Mar 11, 2013 at 04:12:46PM +0100, Marc Kleine-Budde wrote: >> On 03/11/2013 10:17 AM, Ludovic Desroches wrote: >>> On Fri, Mar 08, 2013 at 06:44:05PM +0100, Marc Kleine-Budde wrote: >>>> On 03/08/2013 06:30 PM, ludovic.desroches@atmel.com wrote: >>>>> From: Ludovic Desroches >>>>> >>>>> Add device tree support. >>>>> >>>>> Signed-off-by: Ludovic Desroches >>>>> --- >>>>> .../devicetree/bindings/net/can/atmel-can.txt | 14 ++++ >>>>> drivers/net/can/at91_can.c | 75 ++++++++++= ++++++------ >>>>> 2 files changed, 70 insertions(+), 19 deletions(-) >>>>> create mode 100644 Documentation/devicetree/bindings/net/can/atmel= -can.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/net/can/atmel-can.tx= t b/Documentation/devicetree/bindings/net/can/atmel-can.txt >>>>> new file mode 100644 >>>>> index 0000000..69381db >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/net/can/atmel-can.txt >>>>> @@ -0,0 +1,14 @@ >>>>> +* AT91 CAN * >>>>> + >>>>> +Required properties: >>>>> + - compatible: Should be "atmel,at91sam9263-can" or "atmel,at91sa= m9x5-can" >>>> >>>> On imx we use the oldest SoC with that IP available. Which strategy = are >>>> you following on at91? >>>> >>> >>> We are using the same strategy. >> >> But "atmel,at91sam9x5-can" isn't a specific SoC, probably a SoC family= =2E >> Or are you using "atmel,at91sam9x5-can" for the other devices in the D= T, >> too. >> >=20 > You are right at91sam9x5 is not a specific SoC but a family of SoCs: > at91sam9g25, at91sam9g35, at91sam9x25 and at91sam9x35. This compatible = string > is used for all the devices from and after the at91sam9x5 family: at91s= am9n12, > samad3x, etc. >=20 >> I picked at91sam9x5-can for the non devicetree driver out of the blue,= >> as there was no scheme established, yet. I'm not hanging on that name,= >> I'd rather appreciate to follow the common at91 DT rules. >=20 > It follows at91 Dt rules, we have atmel,at91sam9x5-i2c, atmel,at91sam9x= 5-gpio > and others. That's okay then, just wanted to clarify this. Can you send a v2, then I'll apply the patches. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | ------enig2SPIDKVGVXOTBXUCWNAAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlE9/2wACgkQjTAFq1RaXHNy4gCdHhloTCVEzp+YeFilfyRoLAAq ylwAnjqXSe/mRXjCeg6/VpicUL1ffPoB =UGrr -----END PGP SIGNATURE----- ------enig2SPIDKVGVXOTBXUCWNAAQ--