From: John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Christian Daudt <csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
"arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V7 1/2] ARM: bcm281xx: Add timer driver (driver portion)
Date: Wed, 13 Mar 2013 16:29:56 -0700 [thread overview]
Message-ID: <51410BF4.4040400@linaro.org> (raw)
In-Reply-To: <1363210048-3334-1-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
On 03/13/2013 02:27 PM, Christian Daudt wrote:
> This adds support for the Broadcom timer, used in the following SoCs:
> BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
[snip]
> Signed-off-by: Christian Daudt <csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Acked-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> Acked-by: John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Reviewed-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Hey Olof,
So Christian mentioned you were hoping I'd pull these in through my
tree, but I'd really rather these go via the arch-soc tree, since that
is more likely where they will be tested and more intelligently reviewed.
I've mentioned before my distaste for the drivers/clocksource directory
becoming a dumping ground for arch specific (for the most part arm)
clocksource, and more recently clockevent, drivers. I initially wanted
the drivers/clocksource directory to be only for cross-arch
clocksources, and I fear we'll end up with something like the
drivers/rtc directory where its not entirely clear what hardware you
actually need for a given driver (might as well be rtc-<sha1>.c ;).
That said, I realize I've been overruled on this. :)
But I'd really rather the patch flow for arch specific clocksource and
clockevent drivers go through the arch tree, since there's a better
chance folks will be building and testing against other arch specific
changes that might cause problems. There's just no way for me to be able
to intelligently review these sorts of changes.
Now, if there are changes to the clocksource core code, then I
definitely want to be in the path there. Additionally meta-drivers like
mmio, I should probably be more involved with, so they can be more
properly integrated into the clocksource core. Also for drivers that are
actually arch shared (ie: things like hpet/acpi_pm where ia64 and x86
share them).
But if its arch specific for hardware I don't have, I'd really prefer
the arch maintainer be the upstream path.
Thomas: Am I being too obstinate here? If not, should we drop "F:
drivers/clocksource" from the MAINTAINERS entry?
Christian: Sorry for the confusion on all this!
thanks
-john
next prev parent reply other threads:[~2013-03-13 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 21:27 [PATCH V7 1/2] ARM: bcm281xx: Add timer driver (driver portion) Christian Daudt
2013-03-13 21:27 ` [PATCH V7 2/2] ARM: bcm281xx: Add timer driver (DT portion) Christian Daudt
[not found] ` <1363210048-3334-2-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-03-28 16:07 ` Christian Daudt
[not found] ` <CAGFynZ_YEHbUQxGFgp_SA__4xRge64oQ-y5ypXhV5mhtM2k4+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-02 20:43 ` Olof Johansson
2013-04-02 20:41 ` Olof Johansson
[not found] ` <1363210048-3334-1-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-03-13 23:29 ` John Stultz [this message]
[not found] ` <51410BF4.4040400-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-14 9:16 ` [PATCH V7 1/2] ARM: bcm281xx: Add timer driver (driver portion) Thomas Gleixner
2013-03-14 16:03 ` Arnd Bergmann
[not found] ` <201303141603.02401.arnd-r2nGTMty4D4@public.gmane.org>
2013-03-28 16:03 ` Christian Daudt
[not found] ` <CAGFynZ-8hQLLYuny6V6=9c+dqtAHs51BcH_wPb=k7WdY9FXS3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-28 17:57 ` John Stultz
[not found] ` <5154848D.7010400-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-03-28 19:27 ` Arnd Bergmann
2013-03-28 18:01 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51410BF4.4040400@linaro.org \
--to=john.stultz-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).