devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Vikas Sajjan <vikas.sajjan@linaro.org>,
	linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	l.krishna@samsung.com, devicetree-discuss@lists.ozlabs.org,
	joshi@samsung.com, inki.dae@samsung.com,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name
Date: Mon, 18 Mar 2013 10:50:44 -0500	[thread overview]
Message-ID: <514737D4.8080601@gmail.com> (raw)
In-Reply-To: <514100D9.1000603@gmail.com>

On 03/13/2013 05:42 PM, Sylwester Nawrocki wrote:
> Rob,
> 
> On 03/13/2013 03:39 PM, Rob Herring wrote:
>> I fail to see what the hack is. The order of interrupt properties must
>> be defined by the binding. interrupt-names is auxiliary data and must
>> not be required by an OS.
> 
> It is clear that the order of the interrupts must be defined by the
> bindings. But how useful <resource>-names properties are when we
> cannot define them as required ? If an OS cannot rely on them then
> it must use some other, reliable, method to identify the resources,
> e.g. by hard coding the indexes. If we have to do it then why even
> bother with the <resource>-names properties ? I can see interrupt-names
> property specified as required in at least 2 bindings' documentation
> and all bindings having reg-names property define it as required.
> Are they wrong them ?

You can require the name for a binding definition, but that does not
remove the requirement that the order and index of interrupts also be
defined by the binding. Then it is up to the OS to use names or
hard-coded indexes. Hard-coded indexes are not a hack. This is how FDT
and OF are defined to work.

I'm still not clear how changing the order of the interrupts removes a hack.

Rob

  reply	other threads:[~2013-03-18 15:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 11:26 [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name Vikas Sajjan
2013-03-13 14:39 ` Rob Herring
2013-03-13 22:42   ` Sylwester Nawrocki
2013-03-18 15:50     ` Rob Herring [this message]
2013-03-18 18:11       ` Stephen Warren
2013-03-18 22:27         ` Rob Herring
2013-03-18 23:00           ` Arnd Bergmann
2013-03-18 23:05           ` Stephen Warren
2013-03-19 22:31             ` Sylwester Nawrocki
2013-03-19 21:40       ` Sylwester Nawrocki
2013-03-20  3:22         ` Vikas Sajjan
2013-03-15  4:04   ` Vikas Sajjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514737D4.8080601@gmail.com \
    --to=robherring2@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=inki.dae@samsung.com \
    --cc=joshi@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=l.krishna@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sylvester.nawrocki@gmail.com \
    --cc=vikas.sajjan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).