From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Mallon Subject: Re: [PATCH v3 3/3] backlight: as3711: add OF support Date: Tue, 26 Mar 2013 10:09:30 +1100 Message-ID: <5150D92A.4000206@gmail.com> References: <1363968949-12151-1-git-send-email-g.liakhovetski@gmx.de> <1363968949-12151-4-git-send-email-g.liakhovetski@gmx.de> <20130325154046.82d9337f25cec12b9fa03625@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130325154046.82d9337f25cec12b9fa03625@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Guennadi Liakhovetski , linux-kernel@vger.kernel.org, Mark Brown , Magnus Damm , Simon Horman , devicetree-discuss@lists.ozlabs.org, Samuel Ortiz , Richard Purdie , linux-fbdev@vger.kernel.org, Guennadi Liakhovetski List-Id: devicetree@vger.kernel.org On 26/03/13 09:40, Andrew Morton wrote: > On Fri, 22 Mar 2013 17:15:49 +0100 Guennadi Liakhovetski wrote: > >> Add support for configuring AS3711 backlight driver from DT. >> >> Signed-off-by: Guennadi Liakhovetski >> Reviwed-by: Mark Brown >> --- >> drivers/video/backlight/as3711_bl.c | 118 ++++++++++++++++++++++++++++++++++- >> 1 files changed, 117 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c >> index 41d52fe..123887c 100644 >> --- a/drivers/video/backlight/as3711_bl.c >> +++ b/drivers/video/backlight/as3711_bl.c >> @@ -258,6 +258,109 @@ static int as3711_bl_register(struct platform_device *pdev, >> return 0; >> } >> >> +static int as3711_backlight_parse_dt(struct device *dev) >> +{ >> + struct as3711_bl_pdata *pdata = dev_get_platdata(dev); >> + struct device_node *bl = >> + of_find_node_by_name(dev->parent->of_node, "backlight"), *fb; >> + int ret; > > It's tidier to do > > struct device_node *bl; > > bl = of_find_node_by_name(dev->parent->of_node, "backlight"), *fb; > > and avoid the 80-col trickery. The other reason being that it now becomes much more apparent that *fb is not an argument to of_find_node_by_name(), but a second variable of type struct device_node :-). ~Ryan