* [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node
@ 2013-02-01 5:37 Philip Avinash
2013-02-01 6:10 ` Philip, Avinash
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philip Avinash @ 2013-02-01 5:37 UTC (permalink / raw)
To: b-cousson-l0cyMroinI0, tony-4v6yS6AI5VpBDgjK7y7TUQ,
linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, nsekhar-l0cyMroinI0,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, vaibhav.bedia-l0cyMroinI0,
gururaja.hebbar-l0cyMroinI0, Philip Avinash,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
DT field of "interrupts" was mentioned wrongly as "interrupt" in SPI
node. This went unnoticed as spi-omap2 driver not making use of
interrupt. Fixes the typo.
Signed-off-by: Philip Avinash <avinashphilip-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/am33xx.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index fbcb90b..cece3ad 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -309,7 +309,7 @@
#address-cells = <1>;
#size-cells = <0>;
reg = <0x48030000 0x400>;
- interrupt = <65>;
+ interrupts = <65>;
ti,spi-num-cs = <2>;
ti,hwmods = "spi0";
status = "disabled";
@@ -320,7 +320,7 @@
#address-cells = <1>;
#size-cells = <0>;
reg = <0x481a0000 0x400>;
- interrupt = <125>;
+ interrupts = <125>;
ti,spi-num-cs = <2>;
ti,hwmods = "spi1";
status = "disabled";
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node
2013-02-01 5:37 [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node Philip Avinash
@ 2013-02-01 6:10 ` Philip, Avinash
2013-02-01 11:23 ` Peter Korsgaard
2013-03-28 12:20 ` Benoit Cousson
2 siblings, 0 replies; 4+ messages in thread
From: Philip, Avinash @ 2013-02-01 6:10 UTC (permalink / raw)
To: Cousson, Benoit, tony@atomide.com, linux@arm.linux.org.uk
Cc: linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Nori, Sekhar, Hebbar, Gururaja,
Bedia, Vaibhav, Hiremath, Vaibhav
On Fri, Feb 01, 2013 at 11:07:27, Philip, Avinash wrote:
> DT field of "interrupts" was mentioned wrongly as "interrupt" in SPI
> node. This went unnoticed as spi-omap2 driver not making use of
> interrupt. Fixes the typo.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
Reported-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
Typo mistake was reported by Vaibhav. I forgot to mention "Reported-by"
tag while posting. Add the same on his behalf.
Thanks
Avinash
> ---
> arch/arm/boot/dts/am33xx.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index fbcb90b..cece3ad 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -309,7 +309,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x48030000 0x400>;
> - interrupt = <65>;
> + interrupts = <65>;
> ti,spi-num-cs = <2>;
> ti,hwmods = "spi0";
> status = "disabled";
> @@ -320,7 +320,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x481a0000 0x400>;
> - interrupt = <125>;
> + interrupts = <125>;
> ti,spi-num-cs = <2>;
> ti,hwmods = "spi1";
> status = "disabled";
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node
2013-02-01 5:37 [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node Philip Avinash
2013-02-01 6:10 ` Philip, Avinash
@ 2013-02-01 11:23 ` Peter Korsgaard
2013-03-28 12:20 ` Benoit Cousson
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-02-01 11:23 UTC (permalink / raw)
To: Philip Avinash
Cc: b-cousson, tony, linux, devicetree-discuss, nsekhar, linux-kernel,
vaibhav.bedia, gururaja.hebbar, linux-omap, linux-arm-kernel
>>>>> "Philip" == Philip Avinash <avinashphilip@ti.com> writes:
Philip> DT field of "interrupts" was mentioned wrongly as "interrupt" in SPI
Philip> node. This went unnoticed as spi-omap2 driver not making use of
Philip> interrupt. Fixes the typo.
Philip> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node
2013-02-01 5:37 [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node Philip Avinash
2013-02-01 6:10 ` Philip, Avinash
2013-02-01 11:23 ` Peter Korsgaard
@ 2013-03-28 12:20 ` Benoit Cousson
2 siblings, 0 replies; 4+ messages in thread
From: Benoit Cousson @ 2013-03-28 12:20 UTC (permalink / raw)
To: Philip Avinash
Cc: tony, linux, linux-omap, devicetree-discuss, linux-arm-kernel,
linux-kernel, nsekhar, gururaja.hebbar, vaibhav.bedia, hvaibhav
Hi Philip,
On 02/01/2013 06:37 AM, Philip Avinash wrote:
> DT field of "interrupts" was mentioned wrongly as "interrupt" in SPI
> node. This went unnoticed as spi-omap2 driver not making use of
> interrupt. Fixes the typo.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index fbcb90b..cece3ad 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -309,7 +309,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x48030000 0x400>;
> - interrupt = <65>;
> + interrupts = <65>;
> ti,spi-num-cs = <2>;
> ti,hwmods = "spi0";
> status = "disabled";
> @@ -320,7 +320,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0x481a0000 0x400>;
> - interrupt = <125>;
> + interrupts = <125>;
> ti,spi-num-cs = <2>;
> ti,hwmods = "spi1";
> status = "disabled";
>
Thanks for the fix. Applied with Peter Acked-by. It will be available in the following branch:
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.10/dts
Regards,
Benoit
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-28 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-01 5:37 [PATCH] ARM: dts: AM33XX: Corrects typo in interrupt field in SPI node Philip Avinash
2013-02-01 6:10 ` Philip, Avinash
2013-02-01 11:23 ` Peter Korsgaard
2013-03-28 12:20 ` Benoit Cousson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).