devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Markus Mayer" <mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: of_iomap() and devres questions
Date: Tue, 2 Apr 2013 12:25:59 -0700	[thread overview]
Message-ID: <515B30C7.6040002@broadcom.com> (raw)

Hi all,

I have a few questions regarding the implementation of the of_iomap() 
function.

As it currently stands, the function parses the device tree for the 
device's address and then simply calls ioremap() with that address and 
the associated size.

The first question that has come up is why of_iomap() doesn't also call 
request_mem_region()? Is there a particular reason for it or has it just 
not yet been implemented?

The second question is regarding the use of devres in of_iomap(). Would 
it make sense for of_iomap() to use devm_ioremap() or, better yet, 
devm_request_and_ioremap() instead of simply calling ioremap()?

Thanks,
-Markus

             reply	other threads:[~2013-04-02 19:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 19:25 Markus Mayer [this message]
     [not found] ` <515B30C7.6040002-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-04-03 18:39   ` of_iomap() and devres questions Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515B30C7.6040002@broadcom.com \
    --to=mmayer-dy08kvg/lbpwk0htik3j/w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).