From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up. Date: Wed, 03 Apr 2013 13:34:11 -0600 Message-ID: <515C8433.10001@wwwdotorg.org> References: <1363609781-4045-1-git-send-email-vbyravarasu@nvidia.com> <1363609781-4045-7-git-send-email-vbyravarasu@nvidia.com> <5148C61F.9060708@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5148C61F.9060708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Venu Byravarasu Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 03/19/2013 02:10 PM, Stephen Warren wrote: > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >> Check return values from all GPIO APIs and handle errors accordingly. > >> Remove clk_disable_unprepare which is no more needed. > > The call to clk_disable_unprepare is incorrect in the current code. The > way you worded that, it sounds like it's no longer needed because of the > changes made in this patch. I would re-write that last sentence as: > > Remove the call to clk_disable_unprepare(); this function does not > prepare or enable the clock, so the error path should not disable or > unprepare it. V2 didn't address this review feedback:-(