From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 189B1C43334 for ; Mon, 4 Jul 2022 08:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232898AbiGDIvc (ORCPT ); Mon, 4 Jul 2022 04:51:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231668AbiGDIvb (ORCPT ); Mon, 4 Jul 2022 04:51:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DDCD1145; Mon, 4 Jul 2022 01:51:30 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5232E6601638; Mon, 4 Jul 2022 09:51:28 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656924689; bh=06W+b6RL3osPIk+iBasdY5Wk4bfRW2/i6Z/FRiPkz6w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZNwSe8DAIq9PDy8NpAkLp1m+dZI4MiloI3sMQiWFzvhu6wpBeSbiQUsNuQ2rHhp1B DpQH311R7NfzbMDBmzJB5I24BebrerlG0NoP1y7bqbc3g6pprFizDvN2vOP2EuRZPl TtaVAoKZc9aHynzqWFROX5El67b+I1Zh8+k0Zxz0ugXTR6hfeeYZv3MKrO1FFAwNcy hsUuKf/yNMNmiWyC5h3V1bK8X9rjI7Gg1E/YBPBp8kuFbR6bmRza+ya6hW1ql10yif jOANStZJGVVXHQ3FFkY5/DjCun0+n08JaI8S3QCM8w/4XMwArH6uziMX9pvM1aS/Jj k/zS5NDy/salg== Message-ID: <515d5b84-e625-5908-aa00-b2f03e77fe3b@collabora.com> Date: Mon, 4 Jul 2022 10:51:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 01/11] dt-bindings: arm: mediatek: Add MT8195 Cherry Tomato Chromebooks Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, hsinyi@chromium.org, allen-kh.cheng@mediatek.com, gtk3@inbox.ru, luca@z3ntu.xyz, sam.shih@mediatek.com, sean.wang@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org References: <20220630153316.308767-1-angelogioacchino.delregno@collabora.com> <20220630153316.308767-2-angelogioacchino.delregno@collabora.com> <20220701153111.glbd6gophzipwtjk@notapiano> From: AngeloGioacchino Del Regno In-Reply-To: <20220701153111.glbd6gophzipwtjk@notapiano> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 01/07/22 17:31, Nícolas F. R. A. Prado ha scritto: > On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote: >> Document board compatibles for the MT8195 Cherry platform's >> Tomato Chromebooks, at the time of writing composed of four >> revisions (r0, r1, r2, r3-r4). >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >> index dd6c6e8011f9..3e0afa17ed2e 100644 >> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >> @@ -144,6 +144,19 @@ properties: >> - const: google,spherion-rev0 >> - const: google,spherion >> - const: mediatek,mt8192 >> + - description: Google Tomato (Acer Chromebook Spin 513) > > Hi Angelo, > > searching for "Acer Chromebook Spin 513" I found that there are two different > chromebooks: > > https://www.acer.com/ac/en/US/content/series/acerchromebookspin513 > https://www.acer.com/ac/en/GB/content/series/acerchromebookspin513cp5132h > > The first one is a Qualcomm based one, while the second is mt8195-based, so I > assume that's Tomato. > > They can be telled apart by the model name though: the Qualcomm one is > "CP513-1H", while Tomato is "CP513-2H". So I suggest to add the "CP513-2H" here > in the description, as well as in the cover letter, to avoid confusion between > the two. > Hey Nicolas, nice catch! Even though it would be odd for someone to think that we refer to a Qualcomm powered Chromebook while checking 'mediatek.yaml'... I agree with you, let's specify the model clearly as 'CP513-2H': it fits, so why not! I'll send a v2 soon. Cheers! > Thanks, > Nícolas >