From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/1] of/irq: store IRQ trigger/level in struct resource flags Date: Mon, 08 Apr 2013 16:16:15 -0600 Message-ID: <516341AF.7030207@wwwdotorg.org> References: <1365148088-11175-1-git-send-email-javier.martinez@collabora.co.uk> <51633F26.7000400@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51633F26.7000400@gmail.com> Sender: linux-omap-owner@vger.kernel.org To: Rob Herring Cc: Javier Martinez Canillas , Stephen Warren , devicetree-discuss@lists.ozlabs.org, Rob Herring , Thomas Gleixner , linux-omap , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 04/08/2013 04:05 PM, Rob Herring wrote: > On 04/05/2013 02:48 AM, Javier Martinez Canillas wrote: >> According to Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> the "#interrupt-cells" property of an "interrupt-controller" is used >> to define the number of cells needed to specify a single interrupt. ... >> But the type is never returned so it can't be saved on the IRQ struct >> resource flags member. >> >> This means that drivers that need the IRQ type/level flags defined in >> the DT won't be able to get it. > > But the interrupt controllers that need the information should be able > to get to it via irqd_get_trigger_type. What problem exactly are you > trying to fix? What driver would use this? FYI, that is indeed what I did in sound/soc/codecs/wm8903.c. Thinking back, I'm not sure if that was the right thing or whether I should have sent this same patch:-)