From: Krzysztof Kozlowski <krzk@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Teh Wen Ping <wen.ping.teh@intel.com>
Subject: Re: [PATCH 1/2] dt-bindings: clk: agilex5: Add Agilex5 clock bindings
Date: Wed, 30 Oct 2024 15:36:09 +0100 [thread overview]
Message-ID: <5168bb64-f5cf-4cf4-81c9-3bbf0662a334@kernel.org> (raw)
In-Reply-To: <299bd27b-b5bd-492a-9873-447329e60b67@kernel.org>
On 30/10/2024 15:34, Krzysztof Kozlowski wrote:
> On 30/10/2024 13:02, Steffen Trumtrar wrote:
>> From: Teh Wen Ping <wen.ping.teh@intel.com>
>>
>> Add Intel SoCFPGA Agilex5 clock definition.
>
> Where is the binding? I see only clock IDs. Your commit msg should
> explain such unusual cases.
>
Eh, I just found it in the kernel. Please, do not work on some ancient
kernels. You are duplicating existing code, already accepted or reviewed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-30 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:02 [PATCH 0/2] clk: socfpga: add clock driver for Agilex5 Steffen Trumtrar
2024-10-30 12:02 ` [PATCH 1/2] dt-bindings: clk: agilex5: Add Agilex5 clock bindings Steffen Trumtrar
2024-10-30 14:34 ` Krzysztof Kozlowski
2024-10-30 14:36 ` Krzysztof Kozlowski [this message]
2024-11-04 9:29 ` Steffen Trumtrar
2024-10-30 12:03 ` [PATCH 2/2] clk: socfpga: Add clock driver for Agilex5 Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5168bb64-f5cf-4cf4-81c9-3bbf0662a334@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=wen.ping.teh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).