From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v2] of/base: release the node correctly in of_parse_phandle_with_args() Date: Wed, 17 Apr 2013 06:27:07 -0500 Message-ID: <516E870B.5010303@tabi.org> References: <1365564999-24427-1-git-send-email-Yuantian.Tang@freescale.com> <516E1763.7040206@tabi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Tang Yuantian-B29983 Cc: Grant Likely , devicetree-discuss , "linuxppc-dev@lists.ozlabs.org" , lkml , Rob Herring List-Id: devicetree@vger.kernel.org Tang Yuantian-B29983 wrote: > It was placed on ELSE statement originally, I moved it to IF statement. > Why is it so wrong? Because the logic of the comment applies to the else-condition, not the if-condtion. -- Timur Tabi