From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH] of: export of_get_next_parent Date: Sun, 21 Apr 2013 20:56:38 +0200 Message-ID: <51743666.2070006@gmail.com> References: <1365587227-26137-1-git-send-email-ming.lei@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ming Lei Cc: linux-kernel@vger.kernel.org, Grant Likely , Rob Herring , devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org Hi, On 04/21/2013 02:11 PM, Ming Lei wrote: > On Wed, Apr 10, 2013 at 5:47 PM, Ming Lei wrote: >> The function is called by at least three drivers now: >> >> pinctrl >> mfd/vexpress >> v4l2-core >> >> The 3rd one can be built as module, so export the function to >> avoid build failure. >> >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: devicetree-discuss@lists.ozlabs.org >> Signed-off-by: Ming Lei >> --- >> drivers/of/base.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/of/base.c b/drivers/of/base.c >> index c6443de..a2a0ddc 100644 >> --- a/drivers/of/base.c >> +++ b/drivers/of/base.c >> @@ -382,6 +382,7 @@ struct device_node *of_get_next_parent(struct device_node *node) >> raw_spin_unlock_irqrestore(&devtree_lock, flags); >> return parent; >> } >> +EXPORT_SYMBOL(of_get_next_parent); > > Gentle ping. > > Without the patch, the below build failure is produced every time on -next tree: A similar patch has been queued in the media tree [1]. It should soon appear in -next. [1] http://git.linuxtv.org/mchehab/media-next.git/commitdiff/6695be6863b75620ffa6d422965680ce785cb7c8 Sorry for the trouble. Thanks, Sylwester