* [PATCH] of: export of_get_next_parent
@ 2013-04-10 9:47 Ming Lei
2013-04-21 12:11 ` Ming Lei
0 siblings, 1 reply; 3+ messages in thread
From: Ming Lei @ 2013-04-10 9:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Ming Lei, Grant Likely, Rob Herring, devicetree-discuss
The function is called by at least three drivers now:
pinctrl
mfd/vexpress
v4l2-core
The 3rd one can be built as module, so export the function to
avoid build failure.
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: devicetree-discuss@lists.ozlabs.org
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
drivers/of/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index c6443de..a2a0ddc 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -382,6 +382,7 @@ struct device_node *of_get_next_parent(struct device_node *node)
raw_spin_unlock_irqrestore(&devtree_lock, flags);
return parent;
}
+EXPORT_SYMBOL(of_get_next_parent);
/**
* of_get_next_child - Iterate a node childs
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: export of_get_next_parent
2013-04-10 9:47 [PATCH] of: export of_get_next_parent Ming Lei
@ 2013-04-21 12:11 ` Ming Lei
2013-04-21 18:56 ` Sylwester Nawrocki
0 siblings, 1 reply; 3+ messages in thread
From: Ming Lei @ 2013-04-21 12:11 UTC (permalink / raw)
To: linux-kernel; +Cc: Ming Lei, Grant Likely, Rob Herring, devicetree-discuss
Hi,
On Wed, Apr 10, 2013 at 5:47 PM, Ming Lei <ming.lei@canonical.com> wrote:
> The function is called by at least three drivers now:
>
> pinctrl
> mfd/vexpress
> v4l2-core
>
> The 3rd one can be built as module, so export the function to
> avoid build failure.
>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: devicetree-discuss@lists.ozlabs.org
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> drivers/of/base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index c6443de..a2a0ddc 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -382,6 +382,7 @@ struct device_node *of_get_next_parent(struct device_node *node)
> raw_spin_unlock_irqrestore(&devtree_lock, flags);
> return parent;
> }
> +EXPORT_SYMBOL(of_get_next_parent);
Gentle ping.
Without the patch, the below build failure is produced every time on -next tree:
Building modules, stage 2.
MODPOST 72 modules
ERROR: "of_get_next_parent" [drivers/media/v4l2-core/videodev.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
install kernel and modules
Thanks,
--
Ming Lei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: export of_get_next_parent
2013-04-21 12:11 ` Ming Lei
@ 2013-04-21 18:56 ` Sylwester Nawrocki
0 siblings, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2013-04-21 18:56 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-kernel, Grant Likely, Rob Herring, devicetree-discuss
Hi,
On 04/21/2013 02:11 PM, Ming Lei wrote:
> On Wed, Apr 10, 2013 at 5:47 PM, Ming Lei<ming.lei@canonical.com> wrote:
>> The function is called by at least three drivers now:
>>
>> pinctrl
>> mfd/vexpress
>> v4l2-core
>>
>> The 3rd one can be built as module, so export the function to
>> avoid build failure.
>>
>> Cc: Grant Likely<grant.likely@secretlab.ca>
>> Cc: Rob Herring<rob.herring@calxeda.com>
>> Cc: devicetree-discuss@lists.ozlabs.org
>> Signed-off-by: Ming Lei<ming.lei@canonical.com>
>> ---
>> drivers/of/base.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/of/base.c b/drivers/of/base.c
>> index c6443de..a2a0ddc 100644
>> --- a/drivers/of/base.c
>> +++ b/drivers/of/base.c
>> @@ -382,6 +382,7 @@ struct device_node *of_get_next_parent(struct device_node *node)
>> raw_spin_unlock_irqrestore(&devtree_lock, flags);
>> return parent;
>> }
>> +EXPORT_SYMBOL(of_get_next_parent);
>
> Gentle ping.
>
> Without the patch, the below build failure is produced every time on -next tree:
A similar patch has been queued in the media tree [1]. It should soon
appear in -next.
[1]
http://git.linuxtv.org/mchehab/media-next.git/commitdiff/6695be6863b75620ffa6d422965680ce785cb7c8
Sorry for the trouble.
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-21 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-10 9:47 [PATCH] of: export of_get_next_parent Ming Lei
2013-04-21 12:11 ` Ming Lei
2013-04-21 18:56 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).