From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
nfraprado@collabora.com
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
srv_heupstream@mediatek.com, Chen-Yu Tsai <wenst@chromium.org>,
Ryder Lee <ryder.lee@kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
Date: Mon, 25 Apr 2022 09:53:43 +0200 [thread overview]
Message-ID: <5175fe30-0449-ac5f-7e37-53c07adc433a@linaro.org> (raw)
In-Reply-To: <b850f88f5044eb6cd57bec4fb864e5670618c9e7.camel@mediatek.com>
On 25/04/2022 09:37, allen-kh.cheng wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + watchdog@10007000 {
>>> + compatible = "mediatek,mt8183-wdt",
>>> + "mediatek,mt6589-wdt";
>>> + mediatek,disable-extrst;
>>
>> Did you test your bindings? Does not look like. Please run
>> dt_binding_check (see writing-schema for instructions).
>>
>
> Yes, I have run dt_binding_check.
>
> But example is from original binding txt file.
>
> Is it ok I can write a new expample?
Yes, please. Correct the example in the conversion so it is
reasonable/proper.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-25 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 12:10 [PATCH 0/2] dt-bindings: watchdog: mediatek: Convert binding to YAML Allen-KH Cheng
2022-04-22 12:10 ` [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema Allen-KH Cheng
2022-04-22 15:45 ` Krzysztof Kozlowski
2022-04-22 12:10 ` [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML Allen-KH Cheng
2022-04-22 15:44 ` Krzysztof Kozlowski
[not found] ` <b850f88f5044eb6cd57bec4fb864e5670618c9e7.camel@mediatek.com>
2022-04-25 7:53 ` Krzysztof Kozlowski [this message]
2022-04-25 16:02 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175fe30-0449-ac5f-7e37-53c07adc433a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wenst@chromium.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).