From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C7FC77B6E for ; Wed, 12 Apr 2023 08:26:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbjDLI0c (ORCPT ); Wed, 12 Apr 2023 04:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbjDLI0b (ORCPT ); Wed, 12 Apr 2023 04:26:31 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1035FD5 for ; Wed, 12 Apr 2023 01:26:25 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id ud9so26569391ejc.7 for ; Wed, 12 Apr 2023 01:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681287984; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j2PxCMT017KlB0q2xlNRaCGejb/YR8xF1pSERbKtDdk=; b=ut5iKziJbkhCRP2QUkIsIJ3zForqv1B4G84k9L8PMEQPpjP9OOKF3K5C+Ph++Q6KNC HKnux+4fYx2cgFWxsBYbCa8pRkXzb+3re1ycRPZer16yI6pB/myfNsYVEoOHY9qS4xcN ivX/NPbZT2tWzX2DL7oVASp3eXzF6Rs4ptJP7t9ePPcco5og9bqwREp8AaXY+6HIidNR FMWhXmKXYP7+Lu5YmOy9F719/t5D2W9A2sE3OOUShJpXiNxbrfnne3gYPRzCGp2dy2e2 IPrMycolgbQqm65pcwD2pmRKxybkm+Uiv2HgJUT/Vr9YZk4S2wnyDUAxyFIraFwdjEhC 0vFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681287984; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j2PxCMT017KlB0q2xlNRaCGejb/YR8xF1pSERbKtDdk=; b=jzbi0PgCKcBoTAbY0i2/bVfX5JNaJeMD0rVm4R9T/La0xT6IMDhk986kpOoDykyluG 0MHDLs9PssvmpV3qiQ2L4O/yvvb8AKuhEspg0snBYS8RXzN1ljZTcYBcNoPJhSrpnt2t 8Ra+T20CSUrONvvKI+6ITVsJDgUCeufxB8L0DU+eD5TfNVGiFTD55zeqM9ie6VnqQSCl FMf01rXu3WhbLiLTJ4foV97P0C39IgvjqipKij3HiFpg4HCu/1GRZjYyp/F+jXsqWIXE PzYQpqZj7b+zEUqXTR31z5w+wJSGAofZzxMH4f5u2w5Da2lHk2sv70ln3kzE0c9+pIgR UZFA== X-Gm-Message-State: AAQBX9cqBGXxUUfEAFT7phzLX3M5rbJBoJcalqJQ5Gz9g3kFlvltUyjJ eVtUQPO4qK7ognKe0EW2Ze968w== X-Google-Smtp-Source: AKy350Zr+e/Sw+RDS0dZq1qjB9lNG0/WPzuMdlGLrj16g35xPrnosRO3RyM+ukd++hO58/GtPz1KnQ== X-Received: by 2002:a17:906:bcf0:b0:87b:e105:5d9a with SMTP id op16-20020a170906bcf000b0087be1055d9amr10810505ejb.67.1681287984101; Wed, 12 Apr 2023 01:26:24 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:8fa0:9989:3f72:b14f? ([2a02:810d:15c0:828:8fa0:9989:3f72:b14f]) by smtp.gmail.com with ESMTPSA id tx6-20020a1709078e8600b0094a70a89bffsm3327733ejc.205.2023.04.12.01.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 01:26:23 -0700 (PDT) Message-ID: <517670ca-ba2e-811e-3eb2-7f38011c9690@linaro.org> Date: Wed, 12 Apr 2023 10:26:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 0/7] Add JH7110 USB and USB PHY driver support Content-Language: en-US To: Minda Chen , Emil Renner Berthing , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, linux-riscv@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Mason Huo References: <20230406015216.27034-1-minda.chen@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230406015216.27034-1-minda.chen@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/04/2023 03:52, Minda Chen wrote: > This patchset adds USB driver and USB PHY for the StarFive JH7110 SoC. > USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board. > The patch has been tested on the VisionFive 2 board. > > This patchset should be applied after the patchset [1], [2] and[3]: > [1] https://patchwork.kernel.org/project/linux-riscv/cover/20230314124404.117592-1-xingyu.wu@starfivetech.com/ > [2] https://lore.kernel.org/all/20230315055813.94740-1-william.qiu@starfivetech.com/ > [3] https://patchwork.kernel.org/project/linux-phy/cover/20230315100421.133428-1-changhuang.liang@starfivetech.com/ > > This patchset is base on v6.3-rc4 > > patch 1 is usb phy dt-binding document. > patch 2 is Pcie PHY dt-binding document. > patch 3 is USB 2.0 PHY driver. > patch 4 is PCIe PHY driver. > patch 5 is usb dt-binding document. > patch 6 is the wrapper module driver of Cadence USB3. USB controller IP is Cadence USB3. > patch 7 is USB device tree configuration. > > previous version > --- > v1: https://patchwork.kernel.org/project/linux-usb/cover/20230306095212.25840-1-minda.chen@starfivetech.com/ > v2: https://patchwork.kernel.org/project/linux-usb/cover/20230308082800.3008-1-minda.chen@starfivetech.com/ This is v2. > v3: https://patchwork.kernel.org/project/linux-usb/cover/20230315104411.73614-1-minda.chen@starfivetech.com/ > > changes > v4: > 1. (patch 1) split PCIe PHY dt-binding doc to patch 2. > 2. (patch 2) PCIe PHY add stg and sys con configuration to dt-binding doc. > 3. (patch 3) > - split PCIe PHY driver to patch 4. > - replace dr_mode to phy mode in jh7110_usb2_phy. > 4. (patch 4) > - Makefile and Kconfig sorted by alphabet sequence. > - Add PCIe PHY stg and syscon PHY connection configuration > for USB 3.0. > 5. (patch 5) > - commit message changed. > - merge wrapper dts node and cdns3 node in example. > - Add interrupts, reg, phy and dr_mode in property. > - Add reset-name in property example. > 6. (patch 6) > - For dts node is merged, Using platform_device_alloc and > platform_device_add to generate cadence sub device. > - IOMEM and IRQ resource are passed to Cadence sub device. > - Add PHY ops process for PHY dts setting can not be passed to > Cadence USB driver. > - remove the stg and sys USB 3.0 PHY configuration. > - Change the suspend clock reset and clock enable sequence. > - Get all reset and clock resources before enable them in > cdns_clk_rst_init. > - commit message changed. > 7. (patch 7) > - merge wrapper dts node and cdns3 node in usb dts. > - move the stg and sys USB 3.0 PHY confiuration to > PCIe PHY dts node. > - commit message changed. > - Add reset-names dts. > > v3: > 1. Add patch 1 - 4. Add USB PHY driver and dt-binding doc. > USB PHY codes are moved to patch 3 and patch 4. > 2. (patch 5) > - USB wrapper module dts document is moved to usb directory. > - Remove the 'dr_mode' and 'starfive,usb2-only' setting. > - Some dts format changes. dts binding check pass. > 3. (patch 6) > - Remove the PHY codes. > - Search 'dr_mode' and phy setting from Cadence subnode. > 4. (patch 7) > - Add USB PHY dts configurion. > - 'dr_mode' is moved to Cadence controller submode. > > v2: > 1. (patch 5) dt-binding changes. The document example is the same as dts config. > 2. (patch 6) using dev_err_probe and syscon_regmap_lookup_by_phandle_args function. Some formats changes > 3. (patch 7) dts nodes sorted by the address after @ > > > Minda Chen (7): > dt-bindings: phy: Add StarFive JH7110 USB document > dt-bindings: phy: Add StarFive JH7110 PCIe document > phy: starfive: add JH7110 USB 2.0 PHY driver. > phy: starfive: add JH7110 PCIE 2.0 PHY driver. > dt-bindings: usb: Add StarFive JH7110 USB Bindings YAML schemas > usb: cdns3: add StarFive JH7110 USB driver. > riscv: dts: starfive: add USB dts configuration for JH7110 > > .../phy/starfive,jh7110-pcie-phy.yaml | 58 +++ > .../bindings/phy/starfive,jh7110-usb-phy.yaml | 50 +++ > .../bindings/usb/starfive,jh7110-usb.yaml | 136 +++++++ > MAINTAINERS | 16 + > .../jh7110-starfive-visionfive-2.dtsi | 7 + > arch/riscv/boot/dts/starfive/jh7110.dtsi | 44 ++ > drivers/phy/starfive/Kconfig | 22 + > drivers/phy/starfive/Makefile | 2 + > drivers/phy/starfive/phy-jh7110-pcie.c | 197 +++++++++ > drivers/phy/starfive/phy-jh7110-usb.c | 161 ++++++++ > drivers/usb/cdns3/Kconfig | 11 + > drivers/usb/cdns3/Makefile | 1 + > drivers/usb/cdns3/cdns3-starfive.c | 378 ++++++++++++++++++ > drivers/usb/cdns3/core.h | 3 + > 14 files changed, 1086 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-pcie-phy.yaml > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml > create mode 100644 drivers/phy/starfive/phy-jh7110-pcie.c > create mode 100644 drivers/phy/starfive/phy-jh7110-usb.c > create mode 100644 drivers/usb/cdns3/cdns3-starfive.c > > > base-commit: 0ec57cfa721fbd36b4c4c0d9ccc5d78a78f7fa35 > prerequisite-patch-id: 24a6e3442ed1f5454ffb4a514cfd768436a87090 > prerequisite-patch-id: 55390537360f25c8b9cbfdc30b73ade004f436f7 fatal: bad object 55390537360f25c8b9cbfdc30b73ade004f436f7 What commits do you reference? How are they helpful? Best regards, Krzysztof