From: Mugunthan V N <mugunthanvnm@ti.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-omap@vger.kernel.org
Subject: Re: [net-next PATCH 1/3] drivers: of: add phy fixup support in DT
Date: Thu, 25 Apr 2013 15:34:42 +0530 [thread overview]
Message-ID: <5178FFBA.8050301@ti.com> (raw)
In-Reply-To: <20130425.035649.1109561373283256109.davem@davemloft.net>
On 4/25/2013 1:26 PM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@ti.com>
> Date: Mon, 22 Apr 2013 23:50:36 +0530
>
>> In earlier case phy fixup are added in board file as this is no more the case
>> so adding support for phy register fixup in Device Tree
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> When people put a series of undocumented PHY register writes using
> constants, we tell them it's firmware.
>
> If these PHY registers are actually documented in the driver, write a
> function in that driver which does the programming sequence, then add
> a property that the driver looks for in order to determine whether to
> call that sequence or not.
>
> I don't want people putting random PHY raw programming sequences and
> other crap like that into the OF device nodes. It's extremely
> inelegant and inviting abuse.
>
Will modify the source as per your comments and will submit v2 patch set.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-04-25 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 18:20 [net-next PATCH 0/3] Adding phy register fixup in DT Mugunthan V N
2013-04-22 18:20 ` [net-next PATCH 1/3] drivers: of: add phy fixup support " Mugunthan V N
2013-04-25 7:56 ` David Miller
2013-04-25 10:04 ` Mugunthan V N [this message]
2013-04-25 16:09 ` Ben Hutchings
2013-04-22 18:20 ` [net-next PATCH 2/3] ARM: dts: AM33XX: Add CPSW phy_id device tree data to am335x-evmsk Mugunthan V N
2013-04-22 18:20 ` [net-next PATCH 3/3] ARM: dts: AM33XX: add phy fixup for evm and evmsk boards Mugunthan V N
2013-04-23 8:02 ` [net-next PATCH 0/3] Adding phy register fixup in DT Sascha Hauer
[not found] ` <20130423080257.GQ32299-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-04-24 8:42 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5178FFBA.8050301@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).