devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: linux@arm.linux.org.uk, b-cousson@ti.com, tony@atomide.com,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, hvaibhav@ti.com,
	gururaja.hebbar@ti.com, zonque@gmail.com,
	linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm
Date: Tue, 30 Apr 2013 10:35:42 +0530	[thread overview]
Message-ID: <517F5126.5000509@ti.com> (raw)
In-Reply-To: <ebfab3e9123b3e50b9a9678c1480191addd86d59.1359007746.git.avinashphilip@ti.com>


On 4/29/2013 1:25 PM, Gupta, Pekon wrote:
> From: avinash philip <avinashphilip@ti.com>
> 
> NAND flash connected in am335x-evm on GPMC controller. This patch adds
> device tree node in am3355-evm with GPMC contoller timing for NAND flash
> interface, NAND partition table, ECC scheme, elm handle id.
> 
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> Tested-by: Pekon Gupta <pekon@ti.com>
> 
> ---
> arch/arm/boot/dts/am335x-evm.dts |   98 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 97 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 0423298..1c2fd89 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -26,7 +26,8 @@
>  
>  	am33xx_pinmux: pinmux@44e10800 {
>  		pinctrl-names = "default";
> -		pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>;
> +		pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0
> +			&nandflash_pins_s0>;

Why add this to the board level fallback (called pinctrl hogs, I think)?
This can be part of nand node you added below so that the pinctrl will
take effect when nand gets probed instead of all the time.

Thanks,
Sekhar

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2013-04-30  5:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24  8:02 [PATCH v2 0/3] Add device tree support for NAND flash in am335x-evm Philip Avinash
     [not found] ` <cover.1359007746.git.avinashphilip-l0cyMroinI0@public.gmane.org>
2013-01-24  8:02   ` [PATCH v2 1/3] ARM: dts: AM33XX: Add ELM node Philip Avinash
     [not found]     ` <7fa7438c9a7c5da575d762423815625d523c4689.1359007746.git.avinashphilip-l0cyMroinI0@public.gmane.org>
2013-04-30  5:01       ` [v2,1/3] " Sekhar Nori
2013-01-24  8:02   ` [PATCH v2 2/3] ARM: dts: AM33XX: Add GPMC node Philip Avinash
     [not found]     ` <2645efefa3d36388ff1d4b64255d880b6587770f.1359007746.git.avinashphilip-l0cyMroinI0@public.gmane.org>
2013-05-09  0:16       ` [PATCH v3,2/3] " Tony Lindgren
2013-01-24  8:02   ` [PATCH v2 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm Philip Avinash
2013-04-30  5:05     ` Sekhar Nori [this message]
2013-05-08 23:54       ` [v2, " Tony Lindgren
2013-05-09  4:12         ` Gupta, Pekon
2013-05-20  4:44           ` Gupta, Pekon
2013-05-30  7:24             ` Benoit Cousson
2013-05-30  7:31               ` Gupta, Pekon
2013-05-30  7:36                 ` Gupta, Pekon
2013-05-30  7:39                 ` Benoit Cousson
2013-01-31  9:36   ` [PATCH v2 0/3] Add device tree support for NAND flash in am335x-evm Philip, Avinash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517F5126.5000509@ti.com \
    --to=nsekhar@ti.com \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gururaja.hebbar@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pekon@ti.com \
    --cc=tony@atomide.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).