From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH] irqchip: add support for Marvell Orion SoCs Date: Thu, 02 May 2013 20:54:20 +0200 Message-ID: <5182B65C.8030000@gmail.com> References: <1367519104-19677-1-git-send-email-sebastian.hesselbarth@gmail.com> <5182B18C.4080404@gmail.com> <20130502184514.GE14496@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130502184514.GE14496@n2100.arm.linux.org.uk> Sender: linux-doc-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Grant Likely , Rob Herring , Rob Landley , Thomas Gleixner , Arnd Bergmann , Jason Cooper , Andrew Lunn , Thomas Petazzoni , Gregory Clement , Ezequiel Garcia , Jean-Francois Moine , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 05/02/13 20:45, Russell King - ARM Linux wrote: > On Thu, May 02, 2013 at 08:33:48PM +0200, Sebastian Hesselbarth wrote: >> On 05/02/2013 08:25 PM, Sebastian Hesselbarth wrote: >>> This patch adds an irqchip driver for the main interrupt controller found >>> on Marvell Orion SoCs (Kirkwood, Dove, Orion5x, Discovery Innovation). >>> Corresponding device tree documentation is also added. >>> >>> Signed-off-by: Sebastian Hesselbarth >>> --- >>> Note: This patch triggers a checkpatch warning for >>> WARNING: Avoid CamelCase: >>> >> [...] >>> diff --git a/include/linux/irqchip/orion.h b/include/linux/irqchip/orion.h >>> new file mode 100644 >>> index 0000000..04f7bab >>> --- /dev/null >>> +++ b/include/linux/irqchip/orion.h >>> @@ -0,0 +1,18 @@ >>> +/* >>> + * Marvell Orion SoCs IRQ chip driver header. >>> + * >>> + * Sebastian Hesselbarth >>> + * >>> + * This file is licensed under the terms of the GNU General Public >>> + * License version 2. This program is licensed "as is" without any >>> + * warranty of any kind, whether express or implied. >>> + */ >>> + >>> +#ifndef __LINUX_IRQCHIP_ORION_H >>> +#define __LINUX_IRQCHIP_ORION_H >>> + >>> +#include >> >> First review by myself. The above include is a left-over and >> will be removed in a v2. > > You still need your first level IRQ handlers marked with __exception_irq_entry > which is defined in the above file. > Russell, I know and it is marked with __exception_irq_entry. The above is in include/linux/irqchip/orion.h and only used for .init_irq in machine descriptor later. The irq handler is never exposed to the board file itself, but set within orion_init_irq. This approach has been taked by irqchip/irq-gic.c and irqchip/irq-vic.c rather than adding .handle_irq to the machine descriptor. Sebastian