From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD46C43334 for ; Thu, 14 Jul 2022 09:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238053AbiGNJb6 (ORCPT ); Thu, 14 Jul 2022 05:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238300AbiGNJbp (ORCPT ); Thu, 14 Jul 2022 05:31:45 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 592B72AC53 for ; Thu, 14 Jul 2022 02:31:27 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id x10so1011903ljj.11 for ; Thu, 14 Jul 2022 02:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zUUauj6xWQlBKhAmggWRJiHEqd+Uc2FLH1vOt4Xe2hc=; b=xOohA+X0/I6OlznNLZVRA2ZiFsMx+FSzNZpiqTOZlDUlQldcKqbYKMGrBYmQlZISA6 OmYD3wdYcIQhEJmaVMMF5F4wl448dPyxDp/nscvjJdYjYyFQxduw8m4RBI0L4wdTYx4x oVnVkFi2IYVqFw89GRDrja22fhTDfDz5yvT1jAiMogAAKdo3OOvWJx+T9T/n7WcO9SCl 3WIp5dx9o9YHn8Kv54r3/61aRZG6p+F+MmrI4pzcBHEBYAJqw7Jw3MylRn83m1LfFtyS 6lxNweJ2Pg8BwdZ5GpzfNkz7yl0CJTB+S0QdmJhNHjacRkftXAzytlpPrmKSV/Fh1fRt EJ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zUUauj6xWQlBKhAmggWRJiHEqd+Uc2FLH1vOt4Xe2hc=; b=2grhs9A3cTW/uE0UAlvQqt9Ka+3+YIQ6UYe3pOfqKaP/VIeJKrjXRHS3zzyi4juxWZ /oKv/Mug1dpKw9zp7h85MrpCcoj7xNJOKdCbdEF7D0Yh03+6MFJJWSEKnKdz1hpI+xHq B8qpSMgjTwSuWCWjOHuyxFm4QDJQNCyECR3UXJkSsL1R6Pfi1Zh7Ppo5ws7pOoydURkZ wT5LrQvWA5M8n+kW5F9Td4yXV9UTLvVZ0blXTE7Jal2b+DxQg2lukNL57djwbvmDeu3O aAbDuMPu5dwR1VkCRPTpIrvTaFr3mxCSkt8lghs7f3J0swvsQTuIHvSfbJ2k4r0351Uz sX3g== X-Gm-Message-State: AJIora90ygfzlgw9Bw0ppP0dx3yngVi+EU4rr1NImmkaTl5jnXOQvbjM vmjRemgG4wGCdCwt95ABrpuLCg== X-Google-Smtp-Source: AGRyM1uoaKWpRhIDIlpLpcxTXkubmgIVBqbNjuwoyADerFM3djjjrtYD5bxDk4+gHIcEyN3xNoHMAQ== X-Received: by 2002:a2e:8046:0:b0:25d:82b2:b328 with SMTP id p6-20020a2e8046000000b0025d82b2b328mr3907457ljg.185.1657791085189; Thu, 14 Jul 2022 02:31:25 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id u20-20020a05651220d400b0047255d21132sm260453lfr.97.2022.07.14.02.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 02:31:24 -0700 (PDT) Message-ID: <5187985c-7f86-320b-aee9-a1107c8ce0a7@linaro.org> Date: Thu, 14 Jul 2022 11:31:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Content-Language: en-US To: Johan Hovold , Vinod Koul Cc: Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220707134725.3512-1-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/07/2022 10:12, Johan Hovold wrote: > On Thu, Jul 07, 2022 at 03:46:55PM +0200, Johan Hovold wrote: >> When adding support for SC8280XP to the QMP PHY driver I noticed that >> the PHY provider child node was not described by the current DT schema. >> >> The SC8280XP PHYs also need a second fixed-divider PIPE clock >> ("pipediv2") and I didn't want to have to add a bogus "lane" suffix to >> the clock name just to match the current "pipe0" name so I decided to >> deprecate the unnecessary suffix in the current binding instead. >> >> To be able to add the missing child-node schema and handle device >> specifics like additional PIPE clocks, it quickly became obvious that >> the binding needs to be split up. >> >> This series clean up and fixes some issue with the current schema before >> splitting it up in separate schemas for PCIe, UFS and USB and adding >> missing parts like the child PHY provider nodes. >> >> The MSM8996 PCIe PHY gets its own schema as this is the only non-combo >> PHY that actually provides more than one PHY per IP block. Note that the >> "lane" suffix is still unnecessary and misleading. >> >> The final patches add support for the updated binding to the (recently >> split up) PHY drivers. Included is also a related combo PHY cleanup. >> >> Johan >> >> >> Changes in v2 >> - squash split + cleanup + example patches (Krzysztof) >> - deprecate clock-names instead of dropping suffix (Krzysztof) >> - deprecate reset-names instead of dropping suffix (Krzysztof) >> - flatten child reg if/then schemas (Krzysztof) >> - add back optional vddp-ref-clk to all bindings even though it likely >> only applies to MSM8996/98 UFS (Krzysztof) >> - add missing sc7180 schema to USB binding >> - misc clean ups >> - shorten or drop descriptions >> - drop quotes around $id and $schema (Krzysztof) >> - use maxItems with clock-output-names >> - combine two USB clock+reset schemas >> - add Reviewed-by/Acked-by tags > > Any further comments to this series? > > Vinod, I noticed there was a conflict when rebasing on linux-next due to > commit 85d43a69db2d ("dt-bindings: phy: qcom,qmp: add IPQ8074 PCIe Gen3 > PHY binding"). > I got few comments. Apologies for a slow review, I am a bit overloaded. Best regards, Krzysztof