From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Date: Fri, 14 Jun 2019 11:35:25 +0200 Message-ID: <5188064.YWmxIpmbGp@phil> References: <20190604165802.7338-1-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190604165802.7338-1-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano Cc: linux-kernel@vger.kernel.org, edubezval@gmail.com, manivannan.sadhasivam@linaro.org, Rob Herring , Mark Rutland , Matthias Brugger , Philipp Tomsich , Christoph Muellner , Viresh Kumar , Enric Balletbo i Serra , Emil Renner Berthing , Randy Li , Tony Xie , Vicente Bergas , Klaus Goger , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" List-Id: devicetree@vger.kernel.org Hi Daniel, Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano: > Currently the common thermal zones definitions for the rk3399 assumes > multiple thermal zones are supported by the governors. This is not the > case and each thermal zone has its own governor instance acting > individually without collaboration with other governors. > > As the cooling device for the CPU and the GPU thermal zones is the > same, each governors take different decisions for the same cooling > device leading to conflicting instructions and an erratic behavior. > > As the cooling-maps is about to become an optional property, let's > remove the cpu cooling device map from the GPU thermal zone. > > Signed-off-by: Daniel Lezcano > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 196ac9b78076..e1357e0f60f7 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -821,15 +821,6 @@ > type = "critical"; > }; > }; > - > - cooling-maps { > - map0 { > - trip = <&gpu_alert0>; > - cooling-device = > - <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > - }; > - }; > }; > }; my knowledge of the thermal framework is not that big, but what about the rk3399-devices which further detail the cooling-maps like rk3399-gru-kevin and the rk3399-nanopc-t4 with its fan-handling in the cooling-maps? Heiko