From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [RFC 1/8] serial:st-asc: Add ST ASC driver. Date: Fri, 10 May 2013 17:31:04 +0200 Message-ID: <518D12B8.9070608@codethink.co.uk> References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <1368022248-2153-1-git-send-email-srinivas.kandagatla@st.com> <201305081634.43498.arnd@arndb.de> <20130508153459.GA17186@kroah.com> <518D07FB.7010606@codethink.co.uk> <20130510152355.GB11227@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130510152355.GB11227@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Greg KH Cc: Dave Martin , Srinivas KANDAGATLA , Viresh Kumar , Linus Walleij , Will Deacon , Grant Likely , jslaby@suse.cz, Russell King , Samuel Ortiz , Nicolas Pitre , linux-doc@vger.kernel.org, Stephen Gallimore , linux-serial@vger.kernel.org, Jason Cooper , Arnd Bergmann , Marc Zyngier , devicetree-discuss@lists.ozlabs.org, Rob Herring , Stuart Menefy , Stephen Warren , Dong Aisheng , linux-arm-kernel@lists.infradead.org, Mark Brown , linux-kernel@vger.kerne List-Id: devicetree@vger.kernel.org On 10/05/13 17:23, Greg KH wrote: > On Fri, May 10, 2013 at 04:45:15PM +0200, Ben Dooks wrote: >> On 08/05/13 17:34, Greg KH wrote: >>> On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote: >>>>> +#define ASC_MAJOR 204 >>>>> +#define ASC_MINOR_START 40 >>>> >>>> I don't know what the current policy is on allocating major/minor numbers, >>>> but I'm sure you cannot just reuse one that is already used. >>> >>> I agree, why are you trying to create a new tty device name? Can't you >>> use the existing ttyS name and minor number as you will not have any >>> other type of serial device on this system? >> >> This would be an issue on systems that either accept plug-in cards >> such as PCMCIA/CardBus/PCI or have additional off SoC IO spaces >> where 8250 compatible UARTS could live. > > I thought these were set-top box systems that couldn't accept any > plug-in cards or anything else? This is a SoC, right? The comment covers more than just this particular instance. A lot of SoC devices have expansion interfaces which would accept such UARTs. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius