[PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Krzysztof Kozlowski]

According to schematics the VCCQ2 supply is not connected and the L3G
regulator instead powers up the controller pads (VDD_PX10).  Use correct
supply vdd-hba and drop unsupported current limit for the vdd-hba.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index f29cce5186ac..91aa37ecb259 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -797,8 +797,7 @@ &ufs_mem_hc {
 	vcc-max-microamp = <1300000>;
 	vccq-supply = <&vreg_l1g_1p2>;
 	vccq-max-microamp = <1200000>;
-	vccq2-supply = <&vreg_l3g_1p2>;
-	vccq2-max-microamp = <100>;
+	vdd-hba-supply = <&vreg_l3g_1p2>;
 
 	status = "okay";
 };
-- 
2.34.1

[PATCH 2/6] arm64: dts: qcom: sm8550-qrd: use correct UFS supply

[Krzysztof Kozlowski]

According to schematics the VCCQ2 supply is not connected and the L3G
regulator instead powers up the controller pads (VDD_PX10).  Use correct
supply vdd-hba and drop unsupported current limit for the vdd-hba.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index 2c09ce8aeafd..923b40646e81 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -889,8 +889,7 @@ &ufs_mem_hc {
 	vcc-max-microamp = <1300000>;
 	vccq-supply = <&vreg_l1g_1p2>;
 	vccq-max-microamp = <1200000>;
-	vccq2-supply = <&vreg_l3g_1p2>;
-	vccq2-max-microamp = <100>;
+	vdd-hba-supply = <&vreg_l3g_1p2>;
 
 	status = "okay";
 };
-- 
2.34.1

Re: [PATCH 2/6] arm64: dts: qcom: sm8550-qrd: use correct UFS supply

[Konrad Dybcio]

On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
> According to schematics the VCCQ2 supply is not connected and the L3G
> regulator instead powers up the controller pads (VDD_PX10).  Use correct
> supply vdd-hba and drop unsupported current limit for the vdd-hba.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 3/6] arm64: dts: qcom: sm8450-hdk: add UFS host controller supply

[Krzysztof Kozlowski]

According to schematics the L9B regulator supplies VCCQ (already in DTS)
and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
missing supply for full hardware description, even though it should not
have functional impact.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index bd5e8181f2aa..df9251089cb9 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -1073,6 +1073,7 @@ &ufs_mem_hc {
 	vcc-max-microamp = <1100000>;
 	vccq-supply = <&vreg_l9b_1p2>;
 	vccq-max-microamp = <1200000>;
+	vdd-hba-supply = <&vreg_l9b_1p2>;
 };
 
 &ufs_mem_phy {
-- 
2.34.1

Re: [PATCH 3/6] arm64: dts: qcom: sm8450-hdk: add UFS host controller supply

[Konrad Dybcio]

On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
> According to schematics the L9B regulator supplies VCCQ (already in DTS)
> and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
> missing supply for full hardware description, even though it should not
> have functional impact.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 4/6] arm64: dts: qcom: sm8450-qrd: add UFS host controller supply

[Krzysztof Kozlowski]

According to schematics the L9B regulator supplies VCCQ (already in DTS)
and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
missing supply for full hardware description, even though it should not
have functional impact.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
index 37479327707f..c7d05945aa51 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
@@ -443,6 +443,7 @@ &ufs_mem_hc {
 	vcc-max-microamp = <1100000>;
 	vccq-supply = <&vreg_l9b_1p2>;
 	vccq-max-microamp = <1200000>;
+	vdd-hba-supply = <&vreg_l9b_1p2>;
 };
 
 &ufs_mem_phy {
-- 
2.34.1

Re: [PATCH 4/6] arm64: dts: qcom: sm8450-qrd: add UFS host controller supply

[Konrad Dybcio]

On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
> According to schematics the L9B regulator supplies VCCQ (already in DTS)
> and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
> missing supply for full hardware description, even though it should not
> have functional impact.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 5/6] arm64: dts: qcom: sm8350-hdk: add UFS host controller supply

[Krzysztof Kozlowski]

According to schematics the L9B regulator supplies VCCQ (already in DTS)
and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
missing supply for full hardware description, even though it should not
have functional impact.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index 4013d25a7df3..dd2cb0ccd3cb 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -760,6 +760,7 @@ &ufs_mem_hc {
 	vcc-max-microamp = <800000>;
 	vccq-supply = <&vreg_l9b_1p2>;
 	vccq-max-microamp = <900000>;
+	vdd-hba-supply = <&vreg_l9b_1p2>;
 };
 
 &ufs_mem_phy {
-- 
2.34.1

Re: [PATCH 5/6] arm64: dts: qcom: sm8350-hdk: add UFS host controller supply

[Konrad Dybcio]

On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
> According to schematics the L9B regulator supplies VCCQ (already in DTS)
> and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
> missing supply for full hardware description, even though it should not
> have functional impact.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 6/6] arm64: dts: qcom: sm8350-mtp: add UFS host controller supply

[Krzysztof Kozlowski]

According to schematics the L9B regulator supplies VCCQ (already in DTS)
and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
missing supply for full hardware description, even though it should not
have functional impact.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts
index c5a6c8745606..8bee57f3b25a 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts
@@ -325,6 +325,7 @@ &ufs_mem_hc {
 	vcc-max-microamp = <800000>;
 	vccq-supply = <&vreg_l9b_1p2>;
 	vccq-max-microamp = <900000>;
+	vdd-hba-supply = <&vreg_l9b_1p2>;
 };
 
 &ufs_mem_phy {
-- 
2.34.1

Re: [PATCH 6/6] arm64: dts: qcom: sm8350-mtp: add UFS host controller supply

[Konrad Dybcio]

On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
> According to schematics the L9B regulator supplies VCCQ (already in DTS)
> and the UFS controller pads (VDD_PX10, missing vdd-hba).  Add the
> missing supply for full hardware description, even though it should not
> have functional impact.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Konrad Dybcio]

On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
> According to schematics the VCCQ2 supply is not connected and the L3G
> regulator instead powers up the controller pads (VDD_PX10).  Use correct
> supply vdd-hba and drop unsupported current limit for the vdd-hba.
Why is it unsupported?

Konrad

Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Krzysztof Kozlowski]

On 06/09/2023 13:28, Konrad Dybcio wrote:
> On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
>> According to schematics the VCCQ2 supply is not connected and the L3G
>> regulator instead powers up the controller pads (VDD_PX10).  Use correct
>> supply vdd-hba and drop unsupported current limit for the vdd-hba.
> Why is it unsupported?

Maybe I was here not precise. I move the regulator from vccq2 to
vdd-hba. vccq2 has control of current in UFS core driver. Bindings also
allow it.

vdd-hba does not have current control in UFS (ignored) and bindings do
not allow such max-microamp property. Why? I don't know. That's how it
is done.

Best regards,
Krzysztof

Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Konrad Dybcio]

On 6.09.2023 13:39, Krzysztof Kozlowski wrote:
> On 06/09/2023 13:28, Konrad Dybcio wrote:
>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
>>> According to schematics the VCCQ2 supply is not connected and the L3G
>>> regulator instead powers up the controller pads (VDD_PX10).  Use correct
>>> supply vdd-hba and drop unsupported current limit for the vdd-hba.
>> Why is it unsupported?
> 
> Maybe I was here not precise. I move the regulator from vccq2 to
> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also
> allow it.
Looks like the bindings are out of sync with the driver.

ufshcd_populate_vreg() which parses current is used for both vccq2
and vdd-hba.

Konrad

Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Krzysztof Kozlowski]

On 06/09/2023 13:50, Konrad Dybcio wrote:
> On 6.09.2023 13:39, Krzysztof Kozlowski wrote:
>> On 06/09/2023 13:28, Konrad Dybcio wrote:
>>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
>>>> According to schematics the VCCQ2 supply is not connected and the L3G
>>>> regulator instead powers up the controller pads (VDD_PX10).  Use correct
>>>> supply vdd-hba and drop unsupported current limit for the vdd-hba.
>>> Why is it unsupported?
>>
>> Maybe I was here not precise. I move the regulator from vccq2 to
>> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also
>> allow it.
> Looks like the bindings are out of sync with the driver.
> 
> ufshcd_populate_vreg() which parses current is used for both vccq2
> and vdd-hba.

Just for convenience. The current is not used for vdd-hba. Also:

https://lore.kernel.org/all/20230906113302.201888-1-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof

Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Konrad Dybcio]

On 6.09.2023 14:05, Krzysztof Kozlowski wrote:
> On 06/09/2023 13:50, Konrad Dybcio wrote:
>> On 6.09.2023 13:39, Krzysztof Kozlowski wrote:
>>> On 06/09/2023 13:28, Konrad Dybcio wrote:
>>>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
>>>>> According to schematics the VCCQ2 supply is not connected and the L3G
>>>>> regulator instead powers up the controller pads (VDD_PX10).  Use correct
>>>>> supply vdd-hba and drop unsupported current limit for the vdd-hba.
>>>> Why is it unsupported?
>>>
>>> Maybe I was here not precise. I move the regulator from vccq2 to
>>> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also
>>> allow it.
>> Looks like the bindings are out of sync with the driver.
>>
>> ufshcd_populate_vreg() which parses current is used for both vccq2
>> and vdd-hba.
> 
> Just for convenience. The current is not used for vdd-hba. Also:
> 
> https://lore.kernel.org/all/20230906113302.201888-1-krzysztof.kozlowski@linaro.org/

I see, you're right.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: (subset) [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

[Bjorn Andersson]

On Wed, 06 Sep 2023 12:47:39 +0200, Krzysztof Kozlowski wrote:
> According to schematics the VCCQ2 supply is not connected and the L3G
> regulator instead powers up the controller pads (VDD_PX10).  Use correct
> supply vdd-hba and drop unsupported current limit for the vdd-hba.
> 
> 

Applied, thanks!

[1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply
      commit: 5c72cb3a9a96a5103cba49a1c8f2a2c71b158ab6
[2/6] arm64: dts: qcom: sm8550-qrd: use correct UFS supply
      commit: e485c6e19ae888761d9fc65353722afa0235bbb4
[3/6] arm64: dts: qcom: sm8450-hdk: add UFS host controller supply
      commit: f5688b4914fa5c5b9a0fca1692b82d25ae6cee33
[4/6] arm64: dts: qcom: sm8450-qrd: add UFS host controller supply
      commit: ebad126daf0c70a054b358e276cef453b2fcdc7f
[5/6] arm64: dts: qcom: sm8350-hdk: add UFS host controller supply
      commit: 2c20c75d850574c727e07e615ed55e3d5c2b42db
[6/6] arm64: dts: qcom: sm8350-mtp: add UFS host controller supply
      commit: 201cd8541673f9b553508c2f11dadfab7874addd

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>