From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH v4] extcon: Palmas Extcon Driver Date: Wed, 15 May 2013 00:13:02 +0530 Message-ID: <519285B6.2090701@nvidia.com> References: <1362662506-14823-4-git-send-email-kishon@ti.com> <1367846225-15685-1-git-send-email-kishon@ti.com> <20130506144010.GF13472@opensource.wolfsonmicro.com> <51888D55.3090907@ti.com> <20130507075824.GM7478@sirena.org.uk> <5188CD9C.6010602@ti.com> <20130507104502.GQ7478@sirena.org.uk> <5192017D.6060108@ti.com> <20130514095402.GA9721@xora-build.xora.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130514095402.GA9721@xora-build.xora.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Graeme Gregory Cc: Kishon Vijay Abraham I , Mark Brown , "myungjoo.ham@samsung.com" , "cw00.choi@samsung.com" , "balbi@ti.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , "rob@landley.net" , "ruchika@ti.com" , "tony@atomide.com" , "sameo@linux.intel.com" List-Id: devicetree@vger.kernel.org On Tuesday 14 May 2013 03:24 PM, Graeme Gregory wrote: > On Tue, May 14, 2013 at 02:48:53PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 07 May 2013 04:15 PM, Mark Brown wrote: >>> On Tue, May 07, 2013 at 03:17:08PM +0530, Kishon Vijay Abraham I wrote: >>>> On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote: >>>>>> The platform can provide it's own vbus control in which case this is >>>>>> not needed. >>>>> So why is there no interaction with this external VBUS control and how >>>>> does the driver distinguish between that and an error getting the >>>>> regulator? >>>> The platform specifies if it provides its own VBUS control by the dt >>>> property ti,no_control_vbus. So the driver will give an error only >>>> when *ti,no_control_vbus* is not set. Graeme? >>> That doesn't answer the question about why there's no interaction with >>> the external control... >>> >> Graeme? >> > I already partially answered this, it was written for a SoC where VBUS > generation was in hardware on the SoC with no information. > > I would say if nvidia/Laxman do not need this remove it, if someone ever > uses it then they can re-add it easy enough! I think we really do not require this. Just we need the notification through extcon about the cable connection. We should remove it for avoiding complexity for now.