Re: [PATCH 05/17] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller

Pavel Machek
2014-05-09T09:43:30Z

> > + writel(value, base + offset);
> > +}
> > +
> > +static int dra7xx_pcie_link_up(struct pcie_port *pp)
> > +{
> > + struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pp);
> > + u32 reg = dra7xx_pcie_readl(dra7xx->base, PCIECTRL_DRA7XX_CONF_PHY_CS);
> > +
> > + if (reg & LINK_UP)
> > + return true;
> > + return false;
>
> return reg & LINK_UP;

Function int returning true. I'd change the prototype and would
return !!(reg & ...);

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html