* [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add flag for restoring dll [not found] <1537887875-29494-1-git-send-email-vbadigan@codeaurora.org> @ 2018-09-25 15:04 ` Veerabhadrarao Badiganti 2018-09-25 17:38 ` Evan Green 0 siblings, 1 reply; 3+ messages in thread From: Veerabhadrarao Badiganti @ 2018-09-25 15:04 UTC (permalink / raw) To: adrian.hunter, ulf.hansson, robh+dt Cc: asutoshd, riteshh, stummala, sayalil, evgreen, dianders, Veerabhadrarao Badiganti, Mark Rutland, open list:MULTIMEDIA CARD MMC, SECURE DIGITAL SD AND..., open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list The dll settings of SDHC controller needs to be restored whenever controller clocks are gated. This restoration is needed only on few SDHCI-MSM controllers. This dt flag indicates whether dll restoration is needed or not. Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt index 3720385..207ce36 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt @@ -31,6 +31,8 @@ Optional properties: BUS_OFF states in power irq. Should be specified in pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively. Units uA. +- qcom,restore-dll-config - Flag indicates that restoration of dll config after clock gating + is needed on given platform. This wouldn't be needed for every MSM. Example: sdhc_1: sdhci@f9824900 { @@ -49,6 +51,8 @@ Example: clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; clock-names = "core", "iface"; + + qcom,restore-dll-config; }; sdhc_2: sdhci@f98a4900 { -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add flag for restoring dll 2018-09-25 15:04 ` [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add flag for restoring dll Veerabhadrarao Badiganti @ 2018-09-25 17:38 ` Evan Green 2018-09-27 11:20 ` Veerabhadrarao Badiganti 0 siblings, 1 reply; 3+ messages in thread From: Evan Green @ 2018-09-25 17:38 UTC (permalink / raw) To: vbadigan Cc: adrian.hunter, Ulf Hansson, robh+dt, asutoshd, riteshh, stummala, sayali, Doug Anderson, mark.rutland, linux-mmc, devicetree, linux-kernel On Tue, Sep 25, 2018 at 8:05 AM Veerabhadrarao Badiganti <vbadigan@codeaurora.org> wrote: > > The dll settings of SDHC controller needs to be restored whenever > controller clocks are gated. This restoration is needed only on > few SDHCI-MSM controllers. This dt flag indicates whether dll > restoration is needed or not. > > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > index 3720385..207ce36 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > @@ -31,6 +31,8 @@ Optional properties: > BUS_OFF states in power irq. Should be specified in > pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively. > Units uA. > +- qcom,restore-dll-config - Flag indicates that restoration of dll config after clock gating > + is needed on given platform. This wouldn't be needed for every MSM. > Example: > > sdhc_1: sdhci@f9824900 { > @@ -49,6 +51,8 @@ Example: > > clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; > clock-names = "core", "iface"; > + > + qcom,restore-dll-config; Hi Veera, I'm not sure this is the best approach. It might be better to key this behavior off of the compatible string. Actually I'm noticing now that the binding for this device doesn't include an SoC-specific compatible string, which I think is now the preferred way (eg "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"). I think we should add that to sdhci-msm.txt, then use the compatible string to enable this behavior you're adding now. -Evan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add flag for restoring dll 2018-09-25 17:38 ` Evan Green @ 2018-09-27 11:20 ` Veerabhadrarao Badiganti 0 siblings, 0 replies; 3+ messages in thread From: Veerabhadrarao Badiganti @ 2018-09-27 11:20 UTC (permalink / raw) To: Evan Green Cc: adrian.hunter, Ulf Hansson, robh+dt, asutoshd, riteshh, stummala, sayali, Doug Anderson, mark.rutland, linux-mmc, devicetree, linux-kernel On 9/25/2018 11:08 PM, Evan Green wrote: > On Tue, Sep 25, 2018 at 8:05 AM Veerabhadrarao Badiganti > <vbadigan@codeaurora.org> wrote: >> The dll settings of SDHC controller needs to be restored whenever >> controller clocks are gated. This restoration is needed only on >> few SDHCI-MSM controllers. This dt flag indicates whether dll >> restoration is needed or not. >> >> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> index 3720385..207ce36 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> @@ -31,6 +31,8 @@ Optional properties: >> BUS_OFF states in power irq. Should be specified in >> pairs (lpm, hpm), for BUS_OFF and BUS_ON respectively. >> Units uA. >> +- qcom,restore-dll-config - Flag indicates that restoration of dll config after clock gating >> + is needed on given platform. This wouldn't be needed for every MSM. >> Example: >> >> sdhc_1: sdhci@f9824900 { >> @@ -49,6 +51,8 @@ Example: >> >> clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; >> clock-names = "core", "iface"; >> + >> + qcom,restore-dll-config; > Hi Veera, > I'm not sure this is the best approach. It might be better to key this > behavior off of the compatible string. Actually I'm noticing now that > the binding for this device doesn't include an SoC-specific compatible > string, which I think is now the preferred way (eg > "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5"). I think we should add that > to sdhci-msm.txt, then use the compatible string to enable this > behavior you're adding now. Thanks Evan. I will update this one. > -Evan Thanks, Veera ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-27 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1537887875-29494-1-git-send-email-vbadigan@codeaurora.org>
2018-09-25 15:04 ` [PATCH 1/2] dt-bindings: mmc: sdhci-msm: Add flag for restoring dll Veerabhadrarao Badiganti
2018-09-25 17:38 ` Evan Green
2018-09-27 11:20 ` Veerabhadrarao Badiganti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).