From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices Date: Thu, 16 May 2013 08:29:23 -0400 Message-ID: <5194D123.4060403@ti.com> References: <1368629928-6723-1-git-send-email-eduardo.valentin@ti.com> <1368629928-6723-4-git-send-email-eduardo.valentin@ti.com> <5193A875.1020000@ti.com> <5193B9AA.7020507@ti.com> <20130515165726.GK22508@game.jcrosoft.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VUPFGNDKFBPWOFGDMECU" Return-path: In-Reply-To: <20130515165726.GK22508@game.jcrosoft.org> Sender: linux-kernel-owner@vger.kernel.org To: Jean-Christophe PLAGNIOL-VILLARD Cc: Eduardo Valentin , Benoit Cousson , Russell King , tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org ------enig2VUPFGNDKFBPWOFGDMECU Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 15-05-2013 12:57, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:36 Wed 15 May , Eduardo Valentin wrote: >> On 15-05-2013 11:23, Benoit Cousson wrote: >>> Hi Eduardo, >>> >>> On 05/15/2013 04:58 PM, Eduardo Valentin wrote: >>>> Include bandgap devices for OMAP4460 devices. >>>> >>>> Cc: "Beno=EEt Cousson" >>>> Cc: Tony Lindgren >>>> Cc: Russell King >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin >>>> --- >>>> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/oma= p4460.dtsi >>>> index 2cf227c..e5bfbfe 100644 >>>> --- a/arch/arm/boot/dts/omap4460.dtsi >>>> +++ b/arch/arm/boot/dts/omap4460.dtsi >>>> @@ -29,4 +29,13 @@ >>>> <0 55 0x4>; >>>> ti,hwmods =3D "debugss"; >>>> }; >>>> + >>>> + bandgap { >>>> + reg =3D <0x4a002260 0x4 >>>> + 0x4a00232C 0x4 >>>> + 0x4a002378 0x18>; >>>> + compatible =3D "ti,omap4460-bandgap"; >>>> + interrupts =3D <0 126 4>; /* talert */ >>>> + ti,tshut-gpio =3D <86>; >> >> >> >>> >>> Why do you need a custom attribute for GPIO? Cannot you use the stand= ard >>> one? >> >> I believe it was by your suggestion :-), during the first attempts to >> send this driver. But could not find the thread link :-( sorry. >> >> >> I guess the reasoning to mark it as a ti specific is because it will b= e >> used as IRQ line to treat thermal shutdown (in SW). > so use interrup-parent Jean-Christophe, That will change the controller and break the configuration for the other IRQ line, coming from GIC. >> >>> >>> Where is the gpio controller phandle? >>> >>> Usually it looks like this: >>> >>> gpios =3D <&gpio1 8 0>; >>> >>> >>> Regards, >>> Benoit >>> >>> >>> >> >> >=20 >=20 >=20 >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >=20 >=20 >=20 ------enig2VUPFGNDKFBPWOFGDMECU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlGU0SMACgkQCXcVR3XQvP2gQQD/RT0WjwE07dSClLZ5Y4QjFNfW 0ULPhYRmRSBc4xN34jMBALLcOSY5ysTJxjiQWHai8BQL5gl8K/yhkkdaIew1khfk =3NnZ -----END PGP SIGNATURE----- ------enig2VUPFGNDKFBPWOFGDMECU--