From: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
DTML <devicetree@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
xc-racer2@live.ca, Simon Shields <simon@lineageos.org>
Subject: Re: [PATCH v2 5/7] Input: dt-bindings: tm2-touchkey: Document new keycodes property
Date: Mon, 07 Jan 2019 19:53:20 +0100 [thread overview]
Message-ID: <5195258.Y6g2Bltml4@acerlaptop> (raw)
In-Reply-To: <CAL_JsqLoyQDzyhFvXn=DEucdh-9uwvrcXBK38izeGPdQsuv=Zw@mail.gmail.com>
Dnia czwartek, 3 stycznia 2019 19:27:39 CET Rob Herring pisze:
> On Fri, Dec 28, 2018 at 4:52 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Fri, Dec 28, 2018 at 2:47 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Fri, 28 Dec 2018 16:46:07 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote:
> > > > From: Jonathan Bakker <xc-racer2@live.ca>
> > > >
> > > > Document new optional property for setting custom keycodes.
> > > >
> > > > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> > > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> > > > ---
> > > > Changes from v1:
> > > > - Because key codes could be bigger than 255, use ints for keycodes
> > > > ---
> > > > .../devicetree/bindings/input/cypress,tm2-touchkey.txt | 4 ++++
> > > > 1 file changed, 4 insertions(+)
> > > >
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > Shouldn't this be "linux,keycodes" though?
>
> Sigh, yes.
>
> Rob
I'll send v3 version with this property name fixed (both in documentation and in driver).
Thanks
next prev parent reply other threads:[~2019-01-07 18:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 15:46 [PATCH v2 0/7] Input: tm2-touchkey: Add support for Aries and Midas Paweł Chmiel
2018-12-28 15:46 ` [PATCH v2 1/7] Input: tm2-touchkey: Add support for midas touchkey Paweł Chmiel
2018-12-28 15:46 ` [PATCH v2 2/7] Input: dt-bindings: " Paweł Chmiel
2018-12-28 15:46 ` [PATCH v2 3/7] Input: tm2-touchkey: Correct initial brightness Paweł Chmiel
2018-12-28 15:46 ` [PATCH v2 4/7] Input: tm2-touchkey: Allow specifying custom keycodes Paweł Chmiel
2018-12-28 15:46 ` [PATCH v2 5/7] Input: dt-bindings: tm2-touchkey: Document new keycodes property Paweł Chmiel
2018-12-28 22:47 ` Rob Herring
2018-12-28 22:52 ` Dmitry Torokhov
2019-01-03 18:27 ` Rob Herring
2019-01-07 18:53 ` Paweł Chmiel [this message]
2018-12-28 15:46 ` [PATCH v2 6/7] Input: tm2-touchkey: Add support for aries touchkey variant Paweł Chmiel
2018-12-28 15:46 ` [PATCH v2 7/7] Input: dt-bindings: tm2-touchkey: Add support for aries touchkey Paweł Chmiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195258.Y6g2Bltml4@acerlaptop \
--to=pawel.mikolaj.chmiel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=simon@lineageos.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).