Re: [PATCH 1/6] drivers: bus: add a new driver for WEIM

[Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>]

于 2013年05月22日 00:29, Chaiken, Alison 写道:
>> +	weim: weim at 021b8000 {
>> +		compatible = "fsl,imx6q-weim";
>> +		reg =<0x021b8000 0x4000>;
>> +		interrupts =<0 14 0x04>;
>> +		clocks =<&clks 196>;
>> +		#address-cells =<2>;
>> +		#size-cells =<1>;
>> +		ranges =<0 0 0x08000000 0x08000000>;
>> +
>> +		nor at 0,0 {
>> +			compatible = "cfi-flash";
> Why not use
>
> compatible = "micron,M29W256G", "cfi-flash";
>
> since that's what's on the SABRE-AI board?
>
we may use other NOR. :)
so it's better do not bind the specific NOR, even for SABRE-AI.
I even tested Spanion NOR in the SABRE-AI boards.
>> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
>> index b05ecab..0f997af 100644
>> --- a/drivers/bus/Kconfig
>> +++ b/drivers/bus/Kconfig
>> @@ -4,6 +4,15 @@
>>
>>   menu "Bus devices"
>>
>> +config IMX_WEIM
>> +	tristate "Freescale EIM DRIVER"
>> +	depends on ARCH_MXC&&  MTD_PHYSMAP_OF
> Shawn Guo:
> I do not see how this driver depends on MTD_PHYSMAP_OF.
>
> physmap_of is the module that provides the mapping driver for the cfi-flash that associates memory with the "reg" properties of the nor node.   However, since EIM can also attach Bluetooth module or GPS, the EIM driver itself certainly does not depend on the map module.
>
ok.

i will remove it in next version.

thanks for the comment and review.


Huang Shijie


_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss