From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH RFC v2] media: OF: add sync-on-green endpoint property Date: Sat, 25 May 2013 20:02:30 +0200 Message-ID: <51A0FCB6.7060609@gmail.com> References: <1368710287-8741-1-git-send-email-prabhakar.csengg@gmail.com> <519F4AE7.8000003@gmail.com> <51A0C6A8.5090302@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Prabhakar Lad Cc: DLOS , Mauro Carvalho Chehab , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, LKML , Rob Herring , Kyungmin Park , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Guennadi Liakhovetski , LMML List-Id: devicetree@vger.kernel.org On 05/25/2013 04:26 PM, Prabhakar Lad wrote: >> Thus it might make sense to have only following integer properties (added >> > as needed): >> > >> > composite-sync-active >> > sync-on-green-active >> > sync-on-comp-active >> > sync-on-luma-active >> > >> > This would allow to specify polarity of each signal and at the same time >> > the parsing code could derive synchronisation type. A new field could be >> > added to struct v4l2_of_parallel_bus, e.g. sync_type and it would be filled >> > within v4l2_of_parse_endpoint(). >> > > I am OK with this option. and I hope you meant "struct > v4l2_of_bus_parallel" instead > of " struct v4l2_of_parallel_bus" and to fill sync_type within > v4l2_of_parse_parallel_bus() > and not in v4l2_of_parse_endpoint(). Yes, that's what I meant, sorry for this confusion. Regards, Sylwester