From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver Date: Mon, 27 May 2013 11:52:00 +0530 Message-ID: <51A2FB88.9000303@nvidia.com> References: <1369405896-30246-1-git-send-email-kishon@ti.com> <1369405896-30246-3-git-send-email-kishon@ti.com> <51A2F07F.8070009@samsung.com> <51A2F512.2090907@ti.com> <51A2F84D.9030605@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51A2F84D.9030605@samsung.com> Sender: linux-doc-owner@vger.kernel.org To: Chanwoo Choi Cc: Kishon Vijay Abraham I , "myungjoo.ham@samsung.com" , "balbi@ti.com" , "gg@slimlogic.co.uk" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , "rob@landley.net" , "gregkh@linuxfoundation.org" , "george.cherian@ti.com" , "sameo@linux.intel.com" List-Id: devicetree@vger.kernel.org On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote: > On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: >>> Hi Kishon, >>> >>> I have some comment about this patch >>> and upload modified patch to following repository (extcon-for-palmas). >>> - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c >>> >>> This patchset include patch related to other module >>> ,so I need your opinion to apply this patchset to git repository. >> yeah.. Still there is some confusion with palmas_set_switch_smps10(). I think we can remove it for now and add it separately later. By this at least we can have device mode fully functional in OMAP5. What do you think? >> > I agree your opinion. > > But, I propose some fixes about palmas_set_switch_smps10(). > I dont' prefer to call global function in exton-palmas.c from palmas-regulator.c. > So, Why don't you use regulator consumer instead of global function? > You can register specific regulator for enabling or disabling SMPS10_SWITCH_EN > and then control SMPS10_SWITCH_EN bit through regulator framework in extcon-palmas.c > without calling global function. Along with this, I also like to make the VBUS regulator control to be optional here. Currently it is mandatory.