From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver Date: Mon, 27 May 2013 12:26:14 +0530 Message-ID: <51A3038E.3030405@nvidia.com> References: <1369405896-30246-1-git-send-email-kishon@ti.com> <1369405896-30246-3-git-send-email-kishon@ti.com> <51A2F07F.8070009@samsung.com> <51A2F512.2090907@ti.com> <51A2F84D.9030605@samsung.com> <51A2FB88.9000303@nvidia.com> <51A2FDD2.10309@ti.com> <51A2FEE9.1060905@nvidia.com> <51A30026.2090001@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <51A30026.2090001@ti.com> Sender: linux-doc-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: Chanwoo Choi , "myungjoo.ham@samsung.com" , "balbi@ti.com" , "gg@slimlogic.co.uk" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , "rob@landley.net" , "gregkh@linuxfoundation.org" , "george.cherian@ti.com" , "sameo@linux.intel.com" List-Id: devicetree@vger.kernel.org On Monday 27 May 2013 12:11 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 27 May 2013 12:06 PM, Laxman Dewangan wrote: >> On Monday 27 May 2013 12:01 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Monday 27 May 2013 11:52 AM, Laxman Dewangan wrote: >>>> On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote: >>>>> On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: >>>>>> Hi, >>>>>> >>>>>> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: >>>>>>> Hi Kishon, >>>>>>> >>>>>>> I have some comment about this patch >>>>>>> and upload modified patch to following repository >>>>>>> (extcon-for-palmas). >>>>>>> - >>>>>>> http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/= commit/?h=3Dextcon-for-palmas&id=3Df2b7cb80699cbe1a5fd6c97ef2c600915f8d= 7f2c >>>>>>> >>>>>>> >>>>>>> >>>>>>> This patchset include patch related to other module >>>>>>> ,so I need your opinion to apply this patchset to git repositor= y. >>>>>> yeah.. Still there is some confusion with palmas_set_switch_smps= 10(). >>>>>> I think we can remove it for now and add it separately later. By= this >>>>>> at least we can have device mode fully functional in OMAP5. What= do >>>>>> you think? >>>>>> >>>>> I agree your opinion. >>>>> >>>>> But, I propose some fixes about palmas_set_switch_smps10(). >>>>> I dont' prefer to call global function in exton-palmas.c from >>>>> palmas-regulator.c. >>>>> So, Why don't you use regulator consumer instead of global functi= on? >>>>> You can register specific regulator for enabling or disabling >>>>> SMPS10_SWITCH_EN >>>>> and then control SMPS10_SWITCH_EN bit through regulator framework= in >>>>> extcon-palmas.c >>>>> without calling global function. >>>> Along with this, I also like to make the VBUS regulator control to= be >>>> optional here. Currently it is mandatory. >>> But dint you just tell on my v4 of this patch that you don=92t requ= ire >>> this. >>> http://www.spinics.net/lists/linux-doc/msg10638.html >> In V4, I said remove this VBUS control and my mean was to remove all >> regulator calls for VBUS enabled/disable. >> I saw you just remove the platform data option to have this control = and >> made VBUS mandatory. >> >> Probably some gap here. > Indeed.. > I think then we should stick back to how it was with my v4 or else it > would break OMAP. The regulator calls can't be moved anywhere else as= it > is specific to PALMAS. > I was thinking that extcon driver just detect the cable type and notify= =20 to the client. After cable detection, the next level of configuration=20 should be done in the respective client. On Tegra platform, for ID pin detection, Tegra SOC is capable of detec= t=20 the ID pin presence or Palma is capable. Depending on the board design,= =20 how the ID pin routed from USB connector to PMIC or to Tegra, we enable= =20 corresponding detection logic. Once the USB driver got notification for ID pin presence (by any means)= ,=20 the enabling of VBUS (as the Tegra will work as Host now and need to=20 supply VBUS), is done in USB driver. Not sure about the OMAP here. So in above context, I really do not want to have the VBUS control on=20 extcon driver from Tegra context. If it is require in OMAP context then= =20 please make it as optional so that we can satisfy for Tegra and Omap=20 platform.