From: James Hogan <james.hogan@imgtec.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH v2 9/9] gpio-tz1090-pdc: add TZ1090 PDC gpio driver
Date: Fri, 31 May 2013 13:17:47 +0100 [thread overview]
Message-ID: <51A894EB.3040604@imgtec.com> (raw)
In-Reply-To: <51A628E1.8060805@imgtec.com>
On 29/05/13 17:12, James Hogan wrote:
> On 29/05/13 16:38, Linus Walleij wrote:
>> On Fri, May 24, 2013 at 6:21 PM, James Hogan <james.hogan@imgtec.com> wrote:
>>> +Optional properties:
>>> +- gpio-ranges: Mapping to pin controller pins
>>> +
>>> +- interrupts: Individual syswake interrupts (other GPIOs cannot interrupt)
>>> +
>>> +
>>> +Example:
>>> +
>>> + pdc_gpios: gpio-controller@02006500 {
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> +
>>> + compatible = "img,tz1090-pdc-gpio";
>>> + reg = <0x02006500 0x100>;
>>> +
>>> + interrupt-parent = <&pdc>;
>>> + interrupts = <1 0 0>, /* Syswake 0 */
>>> + <1 1 0>, /* Syswake 1 */
>>> + <1 2 0>; /* Syswake 2 */
>>> + };
>>
>> Interrupt flags seem to be undocumented here.
>
> Hmmm yes, good spot.
Looking again at this, the driver doesn't expose any new interrupts.
These 3 interrupts are simply passed on by the gpio chip's to_irq()
callback. The flags in the example depend entirely on the interrupt
parent, in this case the PDC irq driver in patch 2, so they don't need
documenting here.
Cheers
James
prev parent reply other threads:[~2013-05-31 12:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 16:21 [PATCH v2 0/9] Add some TZ1090 SoC infrastructure James Hogan
2013-05-24 16:21 ` [PATCH v2 2/9] metag: minimal TZ1090 (Comet) " James Hogan
2013-06-13 12:44 ` James Hogan
2013-05-24 16:21 ` [PATCH v2 3/9] irq-imgpdc: add ImgTec PDC irqchip driver James Hogan
[not found] ` <1369412476-14245-1-git-send-email-james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2013-05-24 16:21 ` [PATCH v2 1/9] metag: of_platform_populate from arch generic code James Hogan
2013-06-13 12:44 ` James Hogan
2013-05-24 16:21 ` [PATCH v2 6/9] pinctrl-tz1090: add TZ1090 pinctrl driver James Hogan
2013-05-28 6:48 ` Linus Walleij
2013-05-24 16:21 ` [PATCH v2 7/9] gpio-tz1090: add TZ1090 gpio driver James Hogan
2013-05-29 15:32 ` Linus Walleij
2013-05-29 16:06 ` James Hogan
2013-05-29 19:03 ` Andy Shevchenko
2013-05-24 16:21 ` [PATCH v2 8/9] pinctrl-tz1090-pdc: add TZ1090 PDC pinctrl driver James Hogan
2013-05-29 15:36 ` Linus Walleij
2013-05-24 16:21 ` [PATCH v2 9/9] gpio-tz1090-pdc: add TZ1090 PDC gpio driver James Hogan
2013-05-29 15:38 ` Linus Walleij
2013-05-29 16:12 ` James Hogan
2013-05-31 12:17 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A894EB.3040604@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).