From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v3 1/8] video: xilinxfb: Fix OF probing on little-endian systems Date: Fri, 31 May 2013 08:05:26 -0500 Message-ID: <51A8A016.3000306@tabi.org> References: <0a546c3de84c4650d019274debef0ded9007b36f.1370004925.git.michal.simek@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0a546c3de84c4650d019274debef0ded9007b36f.1370004925.git.michal.simek@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Michal Simek Cc: linux-kernel@vger.kernel.org, Michal Simek , Arnd Bergmann , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Grant Likely , Rob Herring , linux-fbdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On 05/31/2013 07:55 AM, Michal Simek wrote: > - p = (u32 *)of_get_property(op->dev.of_node, "xlnx,dcr-splb-slave-if", NULL); > - tft_access = p ? *p : 0; > + of_property_read_u32(op->dev.of_node, "xlnx,dcr-splb-slave-if", > + &tft_access); This is okay, but just FYI, you could instead have just used be32_to_cpup(). -- Timur Tabi