From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Benoit Cousson <b-cousson@ti.com>
Cc: Florian Vaussard <florian.vaussard@epfl.ch>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding
Date: Fri, 31 May 2013 15:49:31 +0200 [thread overview]
Message-ID: <51A8AA6B.6010608@epfl.ch> (raw)
In-Reply-To: <1369296697-22495-1-git-send-email-florian.vaussard@epfl.ch>
Hello,
Gentle ping. Does someone has any comments on this fix? Can someone
tests on the real hardware?
Regards,
Florian
On 05/23/2013 10:11 AM, Florian Vaussard wrote:
> Commit d36b4cd 'ARM: OMAP2+: Add additional GPMC timing parameters'
> updated GPMC binding, but omap3-devkit8000 was not updated accordingly,
> resulting in a broken configuration.
>
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
> ---
> arch/arm/boot/dts/omap3-devkit8000.dts | 29 +++++++++++++++--------------
> 1 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> index 8a5cdcc..e5b35f5 100644
> --- a/arch/arm/boot/dts/omap3-devkit8000.dts
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -123,20 +123,21 @@
> reg = <0 0 0>; /* CS0, offset 0 */
> nand-bus-width = <16>;
>
> - gpmc,sync-clk = <0>;
> - gpmc,cs-on = <0>;
> - gpmc,cs-rd-off = <44>;
> - gpmc,cs-wr-off = <44>;
> - gpmc,adv-on = <6>;
> - gpmc,adv-rd-off = <34>;
> - gpmc,adv-wr-off = <44>;
> - gpmc,we-off = <40>;
> - gpmc,oe-off = <54>;
> - gpmc,access = <64>;
> - gpmc,rd-cycle = <82>;
> - gpmc,wr-cycle = <82>;
> - gpmc,wr-access = <40>;
> - gpmc,wr-data-mux-bus = <0>;
> + gpmc,device-nand;
> + gpmc,sync-clki-ps = <0>;
> + gpmc,cs-on-ns = <0>;
> + gpmc,cs-rd-off-ns = <44>;
> + gpmc,cs-wr-off-ns = <44>;
> + gpmc,adv-on-ns = <6>;
> + gpmc,adv-rd-off-ns = <34>;
> + gpmc,adv-wr-off-ns = <44>;
> + gpmc,we-off-ns = <40>;
> + gpmc,oe-off-ns = <54>;
> + gpmc,access-ns = <64>;
> + gpmc,rd-cycle-ns = <82>;
> + gpmc,wr-cycle-ns = <82>;
> + gpmc,wr-access-ns = <40>;
> + gpmc,wr-data-mux-bus-ns = <0>;
>
> #address-cells = <1>;
> #size-cells = <1>;
>
--
Florian Vaussard
EPFL - STI - IMT - LSRO1
MEB330 - Station 9
1015 Lausanne / Switzerland
tel: +41 21 693 78 39
fax: +41 21 693 78 07
http://lsro.epfl.ch
next prev parent reply other threads:[~2013-05-31 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 8:11 [PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding Florian Vaussard
2013-05-31 13:49 ` Florian Vaussard [this message]
2013-06-11 14:53 ` Florian Vaussard
2013-06-11 21:54 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8AA6B.6010608@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).