From: Stephen Warren <swarren@wwwdotorg.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: J Keerthy <j-keerthy@ti.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
broonie@opensource.wolfsonmicro.com, rob.herring@calxeda.com,
rob@landley.net, mturquette@linaro.org, sameo@linux.intel.com,
wim@iguana.be, lgirdwood@gmail.com, gg@slimlogic.co.uk,
t-kristo@ti.com, Ian Lartey <ian@slimlogic.co.uk>
Subject: Re: [PATCH] mfd: DT bindings for the palmas family MFD
Date: Mon, 03 Jun 2013 14:38:34 -0600 [thread overview]
Message-ID: <51ACFECA.10209@wwwdotorg.org> (raw)
In-Reply-To: <20130603141851.GG3370@gmail.com>
On 06/03/2013 08:18 AM, Lee Jones wrote:
> On Mon, 03 Jun 2013, J Keerthy wrote:
>> Add the various binding files for the palmas family of chips. There is a
>> top level MFD binding then a seperate binding for regulators IP blocks on chips.
>> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
>> +Example:
>> +
>> +palmas {
>
> Should this be 'palmas@48 {', as it has an address?
It's common to only include the unit-address (@48) if it's needed to
make the node name unique (i.e. if you had multiple palmas devices).
>> diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
> See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt
>
>> + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
>> + 2 - eco, 3 - forced pwm
>
> I've seen lots of sleep-mode properties, can't we define a generic
> one?
Isn't it HW-specific?
next prev parent reply other threads:[~2013-06-03 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 12:08 [PATCH] mfd: DT bindings for the palmas family MFD J Keerthy
2013-06-03 14:18 ` Lee Jones
2013-06-03 20:38 ` Stephen Warren [this message]
2013-06-04 6:24 ` J, KEERTHY
2013-06-04 7:21 ` Lee Jones
2013-06-04 5:28 ` J, KEERTHY
[not found] ` <20130603141851.GG3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-10 10:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ACFECA.10209@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).