From: zhangfei <zhangfei.gao@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v2 2/2] i2c: designware: add two optional property tx/rx-fifo-size
Date: Tue, 11 Jun 2013 10:13:57 +0800 [thread overview]
Message-ID: <51B687E5.307@linaro.org> (raw)
In-Reply-To: <20130610184954.GK4312@tarshish>
On 13-06-11 02:49 AM, Baruch Siach wrote:
> Hi Zhangfei Gao,
>
> On Mon, Jun 10, 2013 at 01:02:55PM +0800, Zhangfei Gao wrote:
>> rx-fifo-size and tx-fifo-size will be updated if provided from dts
>>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>> CC: Baruch Siach <baruch@tkos.co.il>
>> ---
>> .../devicetree/bindings/i2c/i2c-designware.txt | 7 +++++++
>> drivers/i2c/busses/i2c-designware-platdrv.c | 3 +++
>> 2 files changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-designware.txt b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
>> index e42a2ee..61fdb44 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-designware.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-designware.txt
>> @@ -6,6 +6,11 @@ Required properties :
>> - reg : Offset and length of the register set for the device
>> - interrupts : <IRQ> where IRQ is the interrupt number.
>>
>> +Optional properties:
>> +
>> + - rx-fifo-size : 1 cell, Rx fifo threshold
>
> I'd use the word 'size' instead of 'threshold' here. The term 'threshold' is
> used for something else in the datasheet.
>
> baruch
>
OK, will update and resend the patch.
next prev parent reply other threads:[~2013-06-11 2:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 5:02 [PATCH v2 0/2] support hisilicon i2c Zhangfei Gao
2013-06-10 5:02 ` [PATCH v2 1/2] i2c: designware: use module_platform_driver Zhangfei Gao
2013-06-10 5:02 ` [PATCH v2 2/2] i2c: designware: add two optional property tx/rx-fifo-size Zhangfei Gao
[not found] ` <1370840576-15651-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-10 18:49 ` Baruch Siach
2013-06-11 2:13 ` zhangfei [this message]
2013-06-11 2:30 ` [PATCH " Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B687E5.307@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=baruch@tkos.co.il \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dirk.brandewie@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).