From: Stephen Warren <swarren@wwwdotorg.org>
To: Scott Wood <scottwood@freescale.com>
Cc: devicetree-discuss@lists.ozlabs.org,
Thomas Gleixner <tglx@linutronix.de>,
Jerry Huang <Chang-Ming.Huang@freescale.com>,
linux-mmc@vger.kernel.org
Subject: Re: lockdep dump on devtree_lock (involving esdhc)
Date: Wed, 12 Jun 2013 09:43:31 -0600 [thread overview]
Message-ID: <51B89723.7090808@wwwdotorg.org> (raw)
In-Reply-To: <20130611233330.GA15342@home.buserror.net>
On 06/11/2013 05:33 PM, Scott Wood wrote:
> I get the following lockdump output on p2020rdb using
> v3.10-rc5-43-g34376a5. While it's not particularly polite for the
> esdhc driver to be calling OF functions while holding another lock which
> can be acquired from interrupt context, why is devtree_lock usually
> acquired in an irqsafe manner but sometimes not?
>
> Both types of usage were added by the same commit:
>
> commit d6d3c4e656513dcea61ce900f0ecb9ca820ee7cd
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date: Wed Feb 6 15:30:56 2013 -0500
>
> OF: convert devtree lock from rw_lock to raw spinlock
>
> Stephen, you asked about this here:
> http://lkml.indiana.edu/hypermail/linux/kernel/1302.1/01383.html
>
> Did you ever get an answer?
I believe that was fixed by c31a0c0 "of: fix recursive locking in
of_get_next_available_child()".
next prev parent reply other threads:[~2013-06-12 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 23:33 lockdep dump on devtree_lock (involving esdhc) Scott Wood
2013-06-12 7:49 ` Thomas Gleixner
2013-06-12 15:43 ` Stephen Warren [this message]
2013-06-12 16:56 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B89723.7090808@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Chang-Ming.Huang@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mmc@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).