Re: [PATCH 1/9] drm/exynos: use SoC name to identify hdmi version

[김승우 <sw0312.kim@samsung.com>]

Hello Rahul,

On 2013년 06월 11일 23:11, Rahul Sharma wrote:
> Exynos hdmi IP version is named after hdmi specification version i.e.
> 1.3 and 1.4. This versioning mechanism is not sufficient to handle
> the diversity in the hdmi/phy IPs which are present across the exynos
> SoC family.
> 
> This patch changes the hdmi version to the name of the SoC in which
> the IP was introduced for the first time. Same version is applicable
> to all subsequent SoCs having the same IP version.
> 
> Exynos4210 has 1.3 HDMI, i2c mapped phy with configuration set.
> Exynos5250 has 1.4 HDMI, i2c mapped phy with configuration set.
> Exynos5420 has 1.4 HDMI, Platform Bus mapped phy with configuration set.
> 
> Based on the HDMI IP version we cannot decide to pick Exynos5250 phy conf
> and use i2c for data transfer or Exynos5420 phy confs and platform bus
> calls for communication.

Considering your other patch to divide hdmi and hdmiphy, how do you
think using hdmiphy version parsed from hdmiphy dt binding from phy code
instead of using hdmi version for both hdmi and hdmiphy? If that, this
SoC identifying hdmi version is not necessary because there is no change
at least in hdmi side.

And IMO, it seems easy to merge hdmiphy related patch first before
merging patch for exynos5420.

> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |  249 +++++++++++++++++-----------------
>  drivers/gpu/drm/exynos/regs-hdmi.h   |   78 +++++------
>  2 files changed, 164 insertions(+), 163 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 75a6bf3..9384ffc 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -73,9 +73,9 @@ enum HDMI_PACKET_TYPE {
>  	HDMI_PACKET_TYPE_AUI = HDMI_PACKET_TYPE_INFOFRAME + 4
>  };
>  
> -enum hdmi_type {
> -	HDMI_TYPE13,
> -	HDMI_TYPE14,
> +enum hdmi_version {
> +	HDMI_VER_EXYNOS4210,
> +	HDMI_VER_EXYNOS4212,
>  };

<snip>

-- 
Seung-Woo Kim
Samsung Software R&D Center
--